-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Eixt nodeos gracefully if db size is smaller than snapshot size #10936
base: develop
Are you sure you want to change the base?
Eixt nodeos gracefully if db size is smaller than snapshot size #10936
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fix is not better it indicates success on exit.
After this PR, It print two red marked lines to let user know error happened. as below: The final line says nodeos successfully exiting just let user know it is not crashed. I think for most people and most company, a crashed-like end is not recommend. @nksanthosh please make decision we will have this PR or not. |
@heifner - can you elaborate what you are suggesting here? (exit with a non zero error code? or something else?) |
the node failed to start, so non-zero exit code seems correct here. |
The reported issue was that all that was reported was We still want nodeos to return |
Change Description
For EPE 894, if db size if set to smaller than snapshot size, it will print bad_alloc and throw. After this PR, give a meaningful print and gracefully shutdown.
Change Type
Select ONE:
Testing Changes
Select ANY that apply:
Consensus Changes
API Changes
Documentation Additions