Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleaned up handling of failed startup from snapshot #233

Merged
merged 1 commit into from
May 13, 2022
Merged

cleaned up handling of failed startup from snapshot #233

merged 1 commit into from
May 13, 2022

Conversation

ndcgundlach
Copy link
Contributor

@ndcgundlach ndcgundlach commented May 13, 2022 •
edited
Loading

Properly handle exception for db being too small for snapshot. Original eosio PR: EOSIO/eos#10936

Resolves #232

@ndcgundlach ndcgundlach marked this pull request as ready for review May 13, 2022 15:12
oschwaldp-oci
oschwaldp-oci approved these changes May 13, 2022
View reviewed changes
Copy link
Contributor

@oschwaldp-oci oschwaldp-oci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how you moved the logging into the logical flow path in your port of this.

@heifner heifner added the OCI OCI working this issue... label May 13, 2022
@ndcgundlach ndcgundlach merged commit 32d2b4b into main May 13, 2022
@ndcgundlach ndcgundlach deleted the fix_exit_on_db_smaller_than_snapshot branch May 13, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oschwaldp-oci oschwaldp-oci oschwaldp-oci approved these changes

@brianjohnson5972 brianjohnson5972 Awaiting requested review from brianjohnson5972

Assignees
No one assigned
Labels
OCI OCI working this issue...
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exit cleanly when db size too small for snapshot
3 participants
@ndcgundlach @oschwaldp-oci @heifner