This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
block_log performance improvement, and misc. #7756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ansaction only calls add_peer_txn
…a pair as .second was not used.
jgiszczak
suggested changes
Aug 14, 2019
b1bart
suggested changes
Aug 14, 2019
plugins/net_plugin/net_plugin.cpp
Outdated
| @@ -759,29 +756,22 @@ namespace eosio { | |||
| explicit msg_handler( const connection_ptr& conn) : c(conn) {} | |||
|
|
|||
| void operator()( const signed_block& msg ) const { | |||
| EOS_ASSERT( false, plugin_config_exception, "operator()(signed_block&&) should be called" ); | |||
| EOS_ASSERT( false, plugin_config_exception, "Not implemented, call handle_message directly instead" ); | |||
There was a problem hiding this comment.
can this not be a templated operator() that throws the assert and catches all overloads that are not explicitly specified?
There was a problem hiding this comment.
Yes, it can now that no value category of type packed_transaction[_ptr] and signed_block[_ptr] are allowed.
b1bart
approved these changes
Aug 14, 2019
jgiszczak
approved these changes
Aug 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
fc::cfileC-file fc#107 inblock_lognet_pluginof creatingpacked_transactionandsigned_blockdirectly fromnet_messagewithout astd::moveproducer_pluginConsensus Changes
API Changes
Documentation Additions