Function body code size test

[jeffreyssmith2nd]

Change Description

• Adds a unit test to verify that a wasm is rejected when the function body size is too large.
• Updated several exceptions to be more specific.

Consensus Changes

• Consensus Changes

API Changes

• API Changes

Documentation Additions

• Documentation Additions

[swatanabe-b1]

I'm not really fond of testing internal components that are not directly visible to users. We don't really care about exactly where the restriction is enforced as long as the user-visible behavior is fixed.

[swatanabe-b1]

I don't want to have to update tests, just because the implementation changes.

[jeffreyssmith2nd]

The code size here is wrong. It's still 0x1400006, but the correct value is now 0x14000002. The size of the code segment also needs to be adjusted.

I'm not sure I understand, since I'm just using the constraint constant.

[swatanabe-b1]

The code size here is wrong. It's still 0x1400006, but the correct value is now 0x14000002. The size of the code segment also needs to be adjusted.

I'm not sure I understand, since I'm just using the constraint constant.

The original loop emitted more bytes than the constant. It emitted 0x1400004 bytes, because that is the next larger multiple of 7. The new version emits exactly 0x1400000 bytes, which is smaller by 4.

[jeffreyssmith2nd]

The code size here is wrong. It's still 0x1400006, but the correct value is now 0x14000002. The size of the code segment also needs to be adjusted.

I'm not sure I understand, since I'm just using the constraint constant.

The original loop emitted more bytes than the constant. It emitted 0x1400004 bytes, because that is the next larger multiple of 7. The new version emits exactly 0x1400000 bytes, which is smaller by 4.

Ah I see now. It was misleadingly passing, because an exception was being thrown elsewhere in the code. Changing it to maximum_code_size + 4 hits the appropriate exception.