[Doors] Fix issue where NPC's wouldn't open doors because door param overflow #2934
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This fixes a datatype issue preventing NPC's from being able to open doors because their AI logic checks for
door_param > 0
then don't open door.Because
-1
or sub-zero values are being loaded into an unsigned integer, this is overflowing those values into positives causing the discrepancy in behavior.Tested and fixed, in Griegs End, all doors are
-1
door-open-fix.mp4