-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove derived variable gtfgco2 #418
Conversation
Because it can be computed from fgco2 with the area_statistics preprocessor
I'm just in the process of preparing a PR for the GMD paper (ESMValGroup/ESMValTool#1621) and I need to re-open this issue (sorry). I realise that I'm a bit late to the party here, but it's still not strictly possible to fully replace this derived variable with a preprocessor at the moment. (Similarly for the global total integrated primary production derived variable, which is not mentioned here but also needed for this publication.) The Even now, it's not clear that there's a solution where preprocessors can change the dimensions of the output units. @valeriupredoi like to bring up Iris's Can we annul this PR and re-instate the global total fgco2? |
Instead of annulling this PR, is there a solution where area_statistics sum can change the cube's units? |
no, I don't think it's a good idea to revert this PR. Instead, maybe you can create a preprocessor that calculates a flux like in the derivation script that got deleted but rather using dask arrays for laziness (that may be useful for other variables and being a preprocessing function preserves a good degree of generality)? 🍺 |
@valeriupredoi, I think that you're missing the point here. The This means that every preprocessor that uses the |
Because it can be computed from fgco2 with the area_statistics preprocessor, see #83 (comment)
Before you start, please read CONTRIBUTING.md.
Tasks
If you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.
Partially addresses #42