Updates of ocean diagnostics and recipes for GMD-2019-291 (ESMValTool Part II paper)

[ledm]

Before you start, read CONTRIBUTING.md and the guide for diagnostic developers.

Please discuss your idea with the development team before getting started, to avoid disappointment later. The way to do this is to open a new issue on GitHub. If you are planning to modify an existing functionality, please discuss it with the original author(s) by tagging them in the issue.

---

Tasks

• Create an issue to discuss what you are going to do, if you haven't done so already (and add the link at the bottom)
• Give this pull request a descriptive title that can be used as a one line summary in a changelog
• Make sure your code is composed of functions of no more than 50 lines and uses meaningful names for variables
• Circle/CI tests pass. Status can be seen below your pull request. If the tests are failing, click the link to find out why.
• Preferably Codacy code quality checks pass, however a few remaining hard to solve Codacy issues are still acceptable. Status can be seen below your pull request. If there is an error, click the link to find out why. If you suspect Codacy may be wrong, please ask by commenting.
• Please use yamllint to check that your YAML files do not contain mistakes
• Update documentation for the recipe to the doc/sphinx/source/recipes folder
• Update provenance information if needed
• Assign the author(s) of the affected recipe(s) as reviewer(s)

If you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.

---

Closes #1620

[ledm]

This PR is now ready for review. Most of my plots listed here in GMD-2019-291 were already included.

This PR just adds some graphical improvements, a couple new time series diagnostics, and a new recipe.

[bouweandela]

Hi Lee,

Could you please clean up a bit by removing commented out lines from recipes and code? It would also be great if you could have a look at the failing tests on CircleCI. Let me know if you need help!

[ledm]

I've been testing recipe_ocean_amoc.yml from this recipe and it looks like something has changed with the extract_named_regions preprocessor. Line 570 of check.py:

cmor_points = [float(val) for val in coord_info.requested]

This line attempts to convert the requested dimensions into floats. This doesn't work with the strings required for this preprocessor and it fails.

[valeriupredoi]

@jvegasbsc have a look at @ledm comment above please mate, it also seems a bit off to me at first glance too - there could be coords that have strings as points (like typesi) 🍺

[jvegreg]

I will take a look. It should not be too dificult

[valeriupredoi]

that's been fixed yesterday (and merged) - can you please merge master in here? 🍺

[ledm]

that's been fixed yesterday (and merged) - can you please merge master in here? 🍺

Cheers - solved it.

[jvegreg]

I will take a look. It should not be too dificult

Done!. Can you test if ESMValGroup/ESMValCore#657 solves your issue?

[mattiarighi]

@valeriupredoi can you please test this?
It would be nice to have it merged for the final release.

[valeriupredoi]

shall do! but I'd be happy if the conflicts get fixed first - they are scientific stuff and would feel uncomfortable fixing them meself 🍺

[bouweandela]

Why is this commented out?

[tomaslovato]

@ledm I might be able to spend some time in the coming weeks to revamp this stale branch if you think it is still valuable.
I spotted a previous branch in #1331 that looks to me like a precursor of the present one, as I saw similar changes e.g. in diagnostic_timeseries.py... is this correct or there are things to rescue also from #1331 ?