Skip to content
This repository has been archived by the owner on Jul 28, 2024. It is now read-only.

New update #491

Closed
wants to merge 2 commits into from
Closed

New update #491

wants to merge 2 commits into from

Conversation

suprajaarthi
Copy link
Contributor

git

starlightknown
starlightknown suggested changes May 11, 2021
View reviewed changes
data.json
@@ -863,4 +863,10 @@
"imageUrl": "https://user-images.githubusercontent.com/71710239/117578918-55148a00-b10e-11eb-93f4-8d2bd01dcd8c.png",
"issueNumber": 487
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add , to the above bracket and please remove the screenshot in PR. GitHub actions will do that from your issue itself

starlightknown
starlightknown suggested changes May 11, 2021
View reviewed changes
data.json
{
"name": "Supraja Arthi",
"githubUsername": "suprajaarthi",
"imageUrl": "https://github.com/suprajaarthi/awesome-github-profiles/blob/main/git.jpeg",
Copy link
Member

@starlightknown starlightknown May 11, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the image url you get when you upload the image in issue you raise please. This (https://user-images.githubusercontent.com/51900501/117803970-d554ff80-b274-11eb-91de-e62714a56d2f.jpeg)

@suprajaarthi
Copy link
Contributor Author

suprajaarthi commented May 11, 2021 via email

@starlightknown
Copy link
Member

I don't see the changes, let me know if I'm mistaken

@starlightknown starlightknown mentioned this pull request May 11, 2021
Merged
@starlightknown
Copy link
Member

Please close this PR now, noticed the changes in other PR. Thank you

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@starlightknown starlightknown starlightknown requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@suprajaarthi @starlightknown