Update data.json #492

suprajaarthi · 2021-05-11T12:31:33Z

resolve #490

starlightknown · 2021-05-11T12:35:30Z

hi @suprajaarthi could you close the previous PR #491 as it duplicates this. I actually asked you to do changes in the same PR but no worries. Please close the old one

suprajaarthi · 2021-05-11T12:41:08Z

I have closed the issue 491 . Is that ok ?

…

On Tue, May 11, 2021 at 6:05 PM Karuna Tata ***@***.***> wrote: hi @suprajaarthi <https://github.com/suprajaarthi> could you close the previous PR #491 <#491> as it duplicates this. I actually asked you to do changes in the same PR but no worries. Please close the old one — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#492 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AML7AVK6DX2JWCIILVYKWN3TNEQCXANCNFSM44VLBQYQ> .

-- R.M.K. Engineering College - Mail system

starlightknown · 2021-05-11T12:42:27Z

I have closed the issue 491 . Is that ok ?

yes! Thank you :)

suprajaarthi · 2021-05-11T12:45:07Z

Thanks :)

…

On Tue, May 11, 2021 at 6:12 PM Karuna Tata ***@***.***> wrote: I have closed the issue 491 . Is that ok ? yes! Thank you :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#492 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AML7AVOCB6N6IUG5Y7532QDTNEQ4ZANCNFSM44VLBQYQ> .

-- R.M.K. Engineering College - Mail system

schmelto · 2021-05-11T12:49:46Z

data.json

}
+

Suggested change

please remove this line

schmelto · 2021-05-11T20:06:43Z

And could you add resolve #yourissuenumber to the description thus the issue automatically gets closed on pr merge 🙈 this would be great

suprajaarthi · 2021-05-12T08:36:59Z

Sure ! Is the issue resolved now

…

On Wed, May 12, 2021 at 1:37 AM Tom Schmelzer ***@***.***> wrote: And could you add resolve #yourissuenumber to the description thus the issue automatically gets closed on pr merge 🙈 this would be great — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#492 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AML7AVIC3GQAWHYSCEMWUWLTNGE6XANCNFSM44VLBQYQ> .

-- R.M.K. Engineering College - Mail system

schmelto · 2021-05-12T08:40:17Z

please also see my suggestion above (#492 (comment))

suprajaarthi · 2021-05-12T08:52:20Z

Is it fine now

…

On Wed, May 12, 2021 at 2:10 PM Tom Schmelzer ***@***.***> wrote: please also see my suggestion above (#492 (comment) <#492 (comment)> ) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#492 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AML7AVMSW4J3IJJMATP4K7TTNI5IPANCNFSM44VLBQYQ> .

-- R.M.K. Engineering College - Mail system

schmelto · 2021-05-12T09:08:22Z

Is it fine now

Unfortunately not take a look at line 872

suprajaarthi · 2021-05-12T10:34:52Z

Updated , Is it ok ?

…

On Wed, May 12, 2021 at 2:38 PM Tom Schmelzer ***@***.***> wrote: Is it fine now Unfortunately not take a look at line 872 [image: Screenshot_20210512_110730.jpg] <https://user-images.githubusercontent.com/30869493/117949346-53b3af00-b312-11eb-88dd-cd381ee84791.jpg> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#492 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AML7AVO2HWDKMNHRQSUXRY3TNJARZANCNFSM44VLBQYQ> .

-- R.M.K. Engineering College - Mail system

schmelto · 2021-05-12T10:40:30Z

@suprajaarthi you have to commit your changes to patch-1 or you can directly accept the suggestion from me above

starlightknown · 2021-05-12T10:42:47Z

Updated , Is it ok ?

You can accept the changes or commit it

starlightknown · 2021-05-12T10:43:29Z

@suprajaarthi you have to commit your changes to patch-1 or you can directly accept the suggestion from me above

You're fast again xD

suprajaarthi · 2021-05-12T10:49:33Z

Committed :)

…

On Wed, May 12, 2021 at 4:13 PM Karuna Tata ***@***.***> wrote: @suprajaarthi <https://github.com/suprajaarthi> you have to commit your changes to patch-1 or you can directly accept the suggestion from me above You're fast again xD — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#492 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AML7AVM6USCSFMRLUACOBBDTNJLWLANCNFSM44VLBQYQ> .

-- R.M.K. Engineering College - Mail system

schmelto · 2021-05-12T11:21:33Z

Hey @suprajaarthi oh no now its little bit messed up. But no worries we will get to this 🚀

The Data.json should look like something like this. I've marked the lines green (with plus)

...
    {
    "name": "Priyanka Mishra",
    "githubUsername": "priyaankamishra",
    "imageUrl": "https://user-images.githubusercontent.com/71710239/117578918-55148a00-b10e-11eb-93f4-8d2bd01dcd8c.png",
    "issueNumber": 487
+  },
+  {
+    "name": "Supraja Arthi",
+    "githubUsername": "suprajaarthi",
+    "imageUrl": "https://github.com/suprajaarthi/awesome-github-profiles/blob/main/git.jpeg",
+    "issueNumber": 490
  }
]

the ] has to be the last line in the file.

schmelto · 2021-05-12T11:27:22Z

You can also take a look at your Forked GitHub repository. I've created a PR (suprajaarthi#1) here where you can see the changes needed. You can merge it into you patch-1 branch or can dismiss it and make the changes by your own.

suprajaarthi · 2021-05-12T13:05:44Z

Updated the mentioned changes . Thanks

…

On Wed, May 12, 2021 at 4:57 PM Tom Schmelzer ***@***.***> wrote: You can also take a look at your Forked GitHub repository. I've created a PR (suprajaarthi#1 <suprajaarthi#1>) here where you can see the changes needed. You can merge it into you patch-1 branch or can dismiss it and make the changes by your own. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#492 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AML7AVKC7RDMEMNJABHYAP3TNJQ27ANCNFSM44VLBQYQ> .

-- R.M.K. Engineering College - Mail system

data.json

suprajaarthi · 2021-05-12T13:21:12Z

Done👍

…

On Wed, May 12, 2021 at 6:41 PM Tom Schmelzer ***@***.***> wrote: ***@***.**** approved this pull request. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#492 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AML7AVO6IZMHMZUTBFPUJ63TNJ465ANCNFSM44VLBQYQ> .

-- R.M.K. Engineering College - Mail system

Update data.json

20fc60e

starlightknown approved these changes May 11, 2021

View reviewed changes

schmelto reviewed May 11, 2021

View reviewed changes

data.json Outdated

}

Copy link

Contributor

schmelto May 11, 2021 •

edited

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

please remove this line

Update data.json

1624791

suprajaarthi added 2 commits May 12, 2021 18:29

Update data.json

1f0073f

Update data.json

048f84c

schmelto reviewed May 12, 2021

View reviewed changes

data.json Outdated Show resolved Hide resolved

schmelto added 2 commits May 12, 2021 15:09

Update data.json

a312006

Merge branch 'main' into patch-1

f3a2fb6

schmelto approved these changes May 12, 2021

View reviewed changes

schmelto merged commit bacb48b into EddieHubCommunity:main May 12, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update data.json #492

Update data.json #492

suprajaarthi commented May 11, 2021 •

edited by schmelto

Loading

starlightknown commented May 11, 2021

suprajaarthi commented May 11, 2021 via email

starlightknown commented May 11, 2021 •

edited

Loading

suprajaarthi commented May 11, 2021 via email

schmelto May 11, 2021 •

edited

Loading

schmelto commented May 11, 2021 •

edited

Loading

suprajaarthi commented May 12, 2021 via email

schmelto commented May 12, 2021

suprajaarthi commented May 12, 2021 via email

schmelto commented May 12, 2021 •

edited

Loading

suprajaarthi commented May 12, 2021 via email

schmelto commented May 12, 2021

starlightknown commented May 12, 2021 •

edited

Loading

starlightknown commented May 12, 2021

suprajaarthi commented May 12, 2021 via email

schmelto commented May 12, 2021

schmelto commented May 12, 2021

suprajaarthi commented May 12, 2021 via email

suprajaarthi commented May 12, 2021 via email

Update data.json #492

Update data.json #492

Conversation

suprajaarthi commented May 11, 2021 • edited by schmelto Loading

starlightknown commented May 11, 2021

suprajaarthi commented May 11, 2021 via email

starlightknown commented May 11, 2021 • edited Loading

suprajaarthi commented May 11, 2021 via email

schmelto May 11, 2021 • edited Loading

Choose a reason for hiding this comment

schmelto commented May 11, 2021 • edited Loading

suprajaarthi commented May 12, 2021 via email

schmelto commented May 12, 2021

suprajaarthi commented May 12, 2021 via email

schmelto commented May 12, 2021 • edited Loading

suprajaarthi commented May 12, 2021 via email

schmelto commented May 12, 2021

starlightknown commented May 12, 2021 • edited Loading

starlightknown commented May 12, 2021

suprajaarthi commented May 12, 2021 via email

schmelto commented May 12, 2021

schmelto commented May 12, 2021

suprajaarthi commented May 12, 2021 via email

suprajaarthi commented May 12, 2021 via email

suprajaarthi commented May 11, 2021 •

edited by schmelto

Loading

starlightknown commented May 11, 2021 •

edited

Loading

schmelto May 11, 2021 •

edited

Loading

schmelto commented May 11, 2021 •

edited

Loading

schmelto commented May 12, 2021 •

edited

Loading

starlightknown commented May 12, 2021 •

edited

Loading