fix: MPM disable telemetry user choice ignored #5286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphaelcoeffic
approved these changes
Jul 11, 2024
raphaelcoeffic
added
the
bug/regression ↩️
|
Just a nitpick with the description as it was initially confusing... this PR isn't FrSky radio specific per se, but more "the Disable Telem GUI option will only be shown on Frsky radios, thus the bug that is being generally fixed will only be exposed on those radios (at this time)" ... unless of course you set the option manually in the model settings for some reason 🤷 |
pfeerick
changed the title
pfeerick
pushed a commit
that referenced
this pull request
Jul 13, 2024
Option is currently only shown on FrSky radios, hence they are susceptible to this bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5285
Summary of changes: overrides auto detection with user choice for MPM telemetry disabling