lxml, google description, qwant and removing yandex. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why did you remove Yandex? |
EdmundMartin
reviewed
Feb 4, 2023
| @@ -62,12 +63,29 @@ def _check_exceptions(self, res: ScrapeResponse) -> None: | |||
| async def scrape(self, req: ScrapeRequest) -> List[SearchResult]: | |||
| geo = req.geo if req.geo else "en_GB" | |||
| urls = self._paginate(req.term, "", geo, req.count) | |||
| headers = { | |||
There was a problem hiding this comment.
This doesn't actually get applied to the request - as on line 83 - the headers are overriden by the call to self.user_agent() - which is probably what should be providing the headers.
EdmundMartin
reviewed
Feb 4, 2023
| @@ -14,6 +14,7 @@ | |||
| install_requires = [ | |||
| 'aiohttp>=3.6.2', | |||
| 'beautifulsoup4>=4.8.2', | |||
| 'lxml' | |||
There was a problem hiding this comment.
This is an extra dependency which is probably not strictly required to use the package - also the version is not pinned. It would probably be better to allow the user to provide the html.parser implementation they want and default to 'html.parser' if an implementation is not provided.
|
Yandex does not work for me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Nice project, happy to contribute.
Best regards.