-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lxml, google description, qwant and removing yandex. #7
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,12 @@ | ||
from searchit.scrapers.google import GoogleScraper | ||
from searchit.scrapers.yandex import YandexScraper | ||
from searchit.scrapers.bing import BingScraper | ||
from searchit.scrapers.scraper import ScrapeRequest | ||
from searchit.scrapers.bing import BingScraper | ||
from searchit.scrapers.google import GoogleScraper | ||
from searchit.scrapers.qwant import QwantScraper | ||
|
||
|
||
__all__ = [ | ||
"GoogleScraper", | ||
"YandexScraper", | ||
"BingScraper", | ||
"ScrapeRequest", | ||
"BingScraper", | ||
"GoogleScraper", | ||
"QwantScraper", | ||
] |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,6 +14,7 @@ | |
install_requires = [ | ||
'aiohttp>=3.6.2', | ||
'beautifulsoup4>=4.8.2', | ||
'lxml' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is an extra dependency which is probably not strictly required to use the package - also the version is not pinned. It would probably be better to allow the user to provide the html.parser implementation they want and default to 'html.parser' if an implementation is not provided. |
||
] | ||
|
||
|
||
|
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't actually get applied to the request - as on line 83 - the headers are overriden by the call to self.user_agent() - which is probably what should be providing the headers.