Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swap type parameters for /platform data types #2376

Conversation

vecerek
Copy link
Contributor

@vecerek vecerek commented Mar 20, 2024

Type

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Following the reverse of Effect's type args, this PR reverses the type args of @effect/platform/Http's Client type as well. I.e.:Client<R, E,A>becameClient<A, E, R>`.

Related

  • Related Issue #
  • Closes #

@vecerek vecerek requested a review from tim-smart as a code owner March 20, 2024 20:49
Copy link

changeset-bot bot commented Mar 20, 2024

🦋 Changeset detected

Latest commit: 771818a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@effect/platform Minor
@effect/platform-browser Major
@effect/platform-bun Major
@effect/platform-node Major
@effect/platform-node-shared Major
@effect/cli Major
@effect/experimental Major
@effect/rpc-http Major
@effect/rpc Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tim-smart tim-smart force-pushed the avecerek-platform-http-reverse-type-args branch from bf565e4 to 260d901 Compare March 20, 2024 21:52
@tim-smart tim-smart changed the title platform: reverse HttpClient type args swap type parameters for /platform data types Mar 20, 2024
@tim-smart tim-smart changed the base branch from main to next-minor March 20, 2024 21:59
@tim-smart tim-smart merged commit 3940abc into Effect-TS:next-minor Mar 20, 2024
12 checks passed
@github-actions github-actions bot mentioned this pull request Mar 20, 2024
tim-smart added a commit that referenced this pull request Mar 25, 2024
Co-authored-by: Tim <hello@timsmart.co>
tim-smart added a commit that referenced this pull request Mar 31, 2024
Co-authored-by: Tim <hello@timsmart.co>
tim-smart added a commit that referenced this pull request Apr 2, 2024
Co-authored-by: Tim <hello@timsmart.co>
tim-smart added a commit that referenced this pull request Apr 2, 2024
Co-authored-by: Tim <hello@timsmart.co>
tim-smart added a commit that referenced this pull request Apr 3, 2024
Co-authored-by: Tim <hello@timsmart.co>
tim-smart added a commit that referenced this pull request Apr 5, 2024
Co-authored-by: Tim <hello@timsmart.co>
tim-smart added a commit that referenced this pull request Apr 9, 2024
Co-authored-by: Tim <hello@timsmart.co>
tim-smart added a commit that referenced this pull request Apr 12, 2024
Co-authored-by: Tim <hello@timsmart.co>
tim-smart added a commit that referenced this pull request Apr 15, 2024
Co-authored-by: Tim <hello@timsmart.co>
tim-smart added a commit that referenced this pull request Apr 16, 2024
Co-authored-by: Tim <hello@timsmart.co>
tim-smart added a commit that referenced this pull request Apr 16, 2024
Co-authored-by: Tim <hello@timsmart.co>
tim-smart added a commit that referenced this pull request Apr 16, 2024
Co-authored-by: Tim <hello@timsmart.co>
mikearnaldi pushed a commit that referenced this pull request Apr 16, 2024
Co-authored-by: Tim <hello@timsmart.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants