-
-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add concurrency control to Pool options #2865
Conversation
🦋 Changeset detectedLatest commit: 8c59f26 The changes in this PR will be included in the next version bump. This PR includes changesets to release 24 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
00b0908
to
0a3c4aa
Compare
0a3c4aa
to
7a93c23
Compare
7a93c23
to
e975f0e
Compare
permits
and timeToLiveStrategy
to Pool options
d629035
to
ba7f48c
Compare
ba7f48c
to
1398a98
Compare
1398a98
to
95d2f5b
Compare
66d9d50
to
0e0371d
Compare
0b14573
to
a195a6e
Compare
d2ffdca
to
b9b3787
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only minor comments, otherwise this looks great to me - nice work @tim-smart!
Also, I know it's tested through usage but should we add explicit tests for the timeToLiveStrategy
in the Pool
options?
Co-authored-by: Tim Smart <tim.smart@arisechurch.com>
Co-authored-by: Tim Smart <tim.smart@arisechurch.com>
Co-authored-by: Tim Smart <tim.smart@arisechurch.com>
Co-authored-by: Tim Smart <tim.smart@arisechurch.com>
Co-authored-by: Tim Smart <tim.smart@arisechurch.com>
Co-authored-by: Tim Smart <tim.smart@arisechurch.com>
No description provided.