Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add concurrency control to Pool options #2865

Merged
merged 16 commits into from
Jun 4, 2024
Merged

add concurrency control to Pool options #2865

merged 16 commits into from
Jun 4, 2024

Conversation

tim-smart
Copy link
Member

No description provided.

Copy link

changeset-bot bot commented May 28, 2024

🦋 Changeset detected

Latest commit: 8c59f26

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 24 packages
Name Type
effect Minor
@effect/cli Major
@effect/experimental Major
@effect/opentelemetry Major
@effect/platform-browser Major
@effect/platform-bun Major
@effect/platform-node-shared Major
@effect/platform-node Major
@effect/platform Major
@effect/printer-ansi Major
@effect/printer Major
@effect/rpc-http Major
@effect/rpc Major
@effect/schema Major
@effect/sql-mssql Major
@effect/sql-mysql2 Major
@effect/sql-pg Major
@effect/sql-sqlite-bun Major
@effect/sql-sqlite-node Major
@effect/sql-sqlite-react-native Major
@effect/sql-sqlite-wasm Major
@effect/sql Major
@effect/typeclass Major
@effect/vitest Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot changed the base branch from main to next-minor May 28, 2024 00:45
@tim-smart tim-smart marked this pull request as draft May 28, 2024 00:57
@tim-smart tim-smart marked this pull request as ready for review May 28, 2024 01:10
@tim-smart tim-smart marked this pull request as draft May 28, 2024 06:41
@tim-smart tim-smart marked this pull request as ready for review May 28, 2024 23:06
@tim-smart tim-smart changed the title support concurrent access for Pool items add permits and timeToLiveStrategy to Pool options May 28, 2024
@github-actions github-actions bot force-pushed the pool branch 3 times, most recently from 66d9d50 to 0e0371d Compare May 29, 2024 22:36
Copy link
Member

@IMax153 IMax153 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor comments, otherwise this looks great to me - nice work @tim-smart!

Also, I know it's tested through usage but should we add explicit tests for the timeToLiveStrategy in the Pool options?

packages/effect/src/internal/pool.ts Show resolved Hide resolved
@tim-smart tim-smart merged commit 5a754ca into next-minor Jun 4, 2024
12 checks passed
@tim-smart tim-smart deleted the pool branch June 4, 2024 21:36
@github-actions github-actions bot mentioned this pull request Jun 4, 2024
tim-smart added a commit that referenced this pull request Jun 5, 2024
Co-authored-by: Tim Smart <tim.smart@arisechurch.com>
tim-smart added a commit that referenced this pull request Jun 5, 2024
Co-authored-by: Tim Smart <tim.smart@arisechurch.com>
github-actions bot pushed a commit that referenced this pull request Jun 6, 2024
Co-authored-by: Tim Smart <tim.smart@arisechurch.com>
github-actions bot pushed a commit that referenced this pull request Jun 6, 2024
Co-authored-by: Tim Smart <tim.smart@arisechurch.com>
github-actions bot pushed a commit that referenced this pull request Jun 6, 2024
Co-authored-by: Tim Smart <tim.smart@arisechurch.com>
tim-smart added a commit that referenced this pull request Jun 6, 2024
Co-authored-by: Tim Smart <tim.smart@arisechurch.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants