Skip to content

Commit

Permalink
fix: dropdown: removed outer container tabindex (#930)
Browse files Browse the repository at this point in the history 
* fix: dropdown: removed outer container tabindex

* fix: dropdown: introduced overlaywrapper tabindex prop

* fix: dropdown: simplified propname

* fix: dropdown: updated snapshots
  • Loading branch information
@krane-c-eightfold
krane-c-eightfold authored Jan 15, 2025
1 parent 3a05bbb commit 5d05021
Show file tree
Hide file tree
Showing 5 changed files with 182 additions and 0 deletions.
30 changes: 30 additions & 0 deletions src/components/DateTimePicker/DatePicker/Tests/__snapshots__/RangePicker.test.js.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ LoadedCheerio {
"children": Array [
Node {
"attribs": Object {
"aria-label": "",
"autocomplete": "off",
"placeholder": "Start date",
"size": "12",
Expand All @@ -27,12 +28,14 @@ LoadedCheerio {
"prev": null,
"type": "tag",
"x-attribsNamespace": Object {
"aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
"value": undefined,
},
"x-attribsPrefix": Object {
"aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
Expand Down Expand Up @@ -64,6 +67,7 @@ LoadedCheerio {
"children": Array [
Node {
"attribs": Object {
"aria-label": "",
"autocomplete": "off",
"placeholder": "End date",
"size": "12",
Expand All @@ -77,12 +81,14 @@ LoadedCheerio {
"prev": null,
"type": "tag",
"x-attribsNamespace": Object {
"aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
"value": undefined,
},
"x-attribsPrefix": Object {
"aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
Expand Down Expand Up @@ -254,6 +260,7 @@ LoadedCheerio {
"children": Array [
Node {
"attribs": Object {
"aria-label": "",
"autocomplete": "off",
"placeholder": "End date",
"size": "12",
Expand All @@ -267,12 +274,14 @@ LoadedCheerio {
"prev": null,
"type": "tag",
"x-attribsNamespace": Object {
"aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
"value": undefined,
},
"x-attribsPrefix": Object {
"aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
Expand Down Expand Up @@ -410,6 +419,7 @@ LoadedCheerio {
"children": Array [
Node {
"attribs": Object {
"aria-label": "",
"autocomplete": "off",
"placeholder": "Start date",
"size": "12",
Expand All @@ -423,12 +433,14 @@ LoadedCheerio {
"prev": null,
"type": "tag",
"x-attribsNamespace": Object {
"aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
"value": undefined,
},
"x-attribsPrefix": Object {
"aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
Expand Down Expand Up @@ -464,6 +476,7 @@ LoadedCheerio {
"children": Array [
Node {
"attribs": Object {
"aria-label": "",
"autocomplete": "off",
"placeholder": "End date",
"size": "12",
Expand All @@ -477,12 +490,14 @@ LoadedCheerio {
"prev": null,
"type": "tag",
"x-attribsNamespace": Object {
"aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
"value": undefined,
},
"x-attribsPrefix": Object {
"aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
Expand Down Expand Up @@ -627,6 +642,7 @@ LoadedCheerio {
"children": Array [
Node {
"attribs": Object {
"aria-label": "",
"autocomplete": "off",
"placeholder": "Start date",
"size": "12",
Expand All @@ -640,12 +656,14 @@ LoadedCheerio {
"prev": null,
"type": "tag",
"x-attribsNamespace": Object {
"aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
"value": undefined,
},
"x-attribsPrefix": Object {
"aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
Expand Down Expand Up @@ -788,6 +806,7 @@ LoadedCheerio {
"children": Array [
Node {
"attribs": Object {
"aria-label": "",
"autocomplete": "off",
"placeholder": "End date",
"size": "12",
Expand All @@ -801,12 +820,14 @@ LoadedCheerio {
"prev": null,
"type": "tag",
"x-attribsNamespace": Object {
"aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
"value": undefined,
},
"x-attribsPrefix": Object {
"aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
Expand Down Expand Up @@ -842,6 +863,7 @@ LoadedCheerio {
"children": Array [
Node {
"attribs": Object {
"aria-label": "",
"autocomplete": "off",
"placeholder": "Start date",
"size": "12",
Expand All @@ -855,12 +877,14 @@ LoadedCheerio {
"prev": null,
"type": "tag",
"x-attribsNamespace": Object {
"aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
"value": undefined,
},
"x-attribsPrefix": Object {
"aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
Expand Down Expand Up @@ -1005,6 +1029,7 @@ LoadedCheerio {
"children": Array [
Node {
"attribs": Object {
"aria-label": "",
"autocomplete": "off",
"placeholder": "End date",
"size": "12",
Expand All @@ -1018,12 +1043,14 @@ LoadedCheerio {
"prev": null,
"type": "tag",
"x-attribsNamespace": Object {
"aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
"value": undefined,
},
"x-attribsPrefix": Object {
"aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
Expand Down Expand Up @@ -1059,6 +1086,7 @@ LoadedCheerio {
"children": Array [
Node {
"attribs": Object {
"aria-label": "",
"autocomplete": "off",
"placeholder": "Start date",
"size": "12",
Expand All @@ -1072,12 +1100,14 @@ LoadedCheerio {
"prev": null,
"type": "tag",
"x-attribsNamespace": Object {
"aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
"value": undefined,
},
"x-attribsPrefix": Object {
"aria-label": undefined,
"autocomplete": undefined,
"placeholder": undefined,
"size": undefined,
Expand Down
Loading

0 comments on commit 5d05021

Please sign in to comment.