Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dropdown: removed outer container tabindex #930

Conversation

krane-c-eightfold
Copy link
Contributor

@krane-c-eightfold krane-c-eightfold commented Jan 6, 2025

SUMMARY:

as role of overlay container is generic but it may not be focusable at all times

changes- added prop overlayTabIndex to set tabindex generically as well

GITHUB ISSUE (Open Source Contributors)

N/A

JIRA TASK (Eightfold Employees Only):

https://eightfoldai.atlassian.net/browse/ENG-99020

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

CASE: if overlay container is passed to component and its role is set as presentation then container should not be focusable only options should be focusable
this will affect dropdown component's overlay container

  • navigate to /refer
  • press tab until you reach share position button
  • open menu by pressing ENTER
  • when you open focus will shift to 1st element in ment
  • after pressing shift tab focus should move to element and not the parent element
Screen.Recording.2025-01-16.at.2.45.41.PM.mov

Copy link

codesandbox-ci bot commented Jan 6, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@sravichandran-eightfold sravichandran-eightfold merged commit 5d05021 into EightfoldAI:main Jan 15, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants