fix: dropdown: removed outer container tabindex #930
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
as role of overlay container is generic but it may not be focusable at all times
changes- added prop overlayTabIndex to set tabindex generically as well
GITHUB ISSUE (Open Source Contributors)
N/A
JIRA TASK (Eightfold Employees Only):
https://eightfoldai.atlassian.net/browse/ENG-99020
CHANGE TYPE:
TEST COVERAGE:
TEST PLAN:
CASE: if overlay container is passed to component and its role is set as presentation then container should not be focusable only options should be focusable
this will affect dropdown component's overlay container
Screen.Recording.2025-01-16.at.2.45.41.PM.mov