-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renepay uses getroutes #7633
Draft
Lagrang3
wants to merge
30
commits into
ElementsProject:master
Choose a base branch
from
Lagrang3:renepay-asks-rene
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Renepay uses getroutes #7633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lagrang3
force-pushed
the
renepay-asks-rene
branch
from
September 2, 2024 16:12
4066423
to
c30ca3c
Compare
Lagrang3
force-pushed
the
renepay-asks-rene
branch
4 times, most recently
from
September 19, 2024 08:29
944d20d
to
fa243fe
Compare
Lagrang3
force-pushed
the
renepay-asks-rene
branch
2 times, most recently
from
September 23, 2024 08:11
307f924
to
2ac8830
Compare
To be able to write a route_exclusion to a json stream. Changelog-None. Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Disabled nodes and channels are now saved into a tal_arr of type strut route_exclution. Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Changelog-EXPERIMENTAL: askrene: add askrene-disable-channel RPC Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Use a bitmap to mark disabled channels instead of tweaking values in localmods. Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Changelog-EXPERIMENTAL: Renepay uses getroutes rpc to obtain payment routes. Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Remove getmychannels payment modifier, the task to evaluate local channels is performed by askrene. Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
For every route hint (bolt11) create local channel with askrene-create-channel RPC. Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Remove unused update of the uncertainty network. The uncertainty network is now handled by askrene. Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Uses askrene-inform-channel to disable channels that meet renepay filter criteria. Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Prefer the provided API to work with amount_msat and fp16. Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Preceding the introduction of askrene we needed to make a gossmap refresh at every payment cycle to ensure to pick up the udpates in the gossip store due to "addgossip" RPCs are called from the messages of failed onions. With askrene this is no longer necessary. Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Resolve multiple RPC calls before moving to the next payment state. Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
We do not move to the next payment step until all sendpay RPCs are finished. We flag routes that fail the sendpay call. Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
For every route we send we make a call to askrene-reserve. Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
The new uncertainty network will be handled by askrene. Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Disable channels and nodes using askrene API. Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Use the dedicated API for disabling channels instead of workarounds. Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
- remove unused local_gossmods - fix failed RPC call to askrene-age when RENEPAY_LAYER does not yet exist - fix plugin hanging if there are no routehints in the invoice Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Lagrang3
force-pushed
the
renepay-asks-rene
branch
from
September 26, 2024 06:32
2ac8830
to
192932e
Compare
Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
- use a single datatype for RPC calls in routetracker and routefail, - call askrene-unreserve for every route after sendpay notification, - call askrene-inform-channel for failed routes. Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renepay uses getroutes
Description
In renepay we call
getroutes
RPC instead of computing routes internally.Changes Made
askrene
andrenepay
will use its API to obtain routes.Additional Notes
Built on top of #7693