Adding askrene-disable-channel #7693
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be able to write a route_exclusion to a json stream. Changelog-None. Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Disabled nodes and channels are now saved into a tal_arr of type strut route_exclution. Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Lagrang3
force-pushed
the
askrene-disable-channel
branch
from
6907ed1
to
a0f874e
Compare
ShahanaFarooqui
force-pushed
the
askrene-disable-channel
branch
from
a0f874e
to
71c3754
Compare
Changelog-EXPERIMENTAL: askrene: add askrene-disable-channel RPC Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Use a bitmap to mark disabled channels instead of tweaking values in localmods. Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
ShahanaFarooqui
force-pushed
the
askrene-disable-channel
branch
from
71c3754
to
f9bc499
Compare
|
Definitely need this interface, I agree. But I prefer to fix the gossmap_update_localchan semantics, otherwise there is a potential hole if we apply a modification and then the channel in the underlying gossip_store is removed: we would have the same crash. Also, we should not combine nodes and channels in the report output: harsh experience has lead us to now avoid things which don't have simply types (grpc interface has strong types, making this awkward). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can think of a way to effectively disable a channel in
askrene: by callingaskrene-inform-channeland set themaximum_msatto 0. But it seems like a workaround way. I think since we already have anaskrene-disable-nodecommand, we should alsosupport an
askrene-disable-channelcommand as well.I have also refactored the way channels are marked as disabled.
Previously we had disabled channels by using
gossmap_local_updatechancall which would produce a plugin crashwhen calling
getroutesif we disable a channel that either doesn't exist or it is defined in a layer that we don't usein that call. Now instead we build a bitmap of disabled channels that we pass on to the MCF solver. The bitmap uses the indexes of the channels relative to the final gossmap, ie. the public gossip plus all localmods coming from the layers.