util: fix crash on bare gs://bucket with no path
#14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running `gsutil ls gs://some-bucket-name` with no trailing slash used to
crash with:
thread 'main' panicked at 'byte index 1 is out of bounds of ``', src/util.rs:162:32
It now behaves the same as upstream `gsutil`: that is, it is equivalent
to the same URL if its path part were a single slash.
wchargin-branch: fix-bare-bucket
wchargin-source: e75a39aade536c955c1caca71bf6938a31886a43
Jake-Shadle
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
gsutil ls gs://some-bucket-namewith no trailing slash used tocrash with:
It now behaves the same as upstream
gsutil: that is, it is equivalentto the same URL if its path part were a single slash.
Fixes #12.
wchargin-branch: fix-bare-bucket