Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: fix crash on bare gs://bucket with no path #14

Merged
merged 1 commit into from
Jul 31, 2023
Merged

util: fix crash on bare gs://bucket with no path #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/util.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,11 @@ pub fn gs_url_to_object_id(url: &url::Url) -> anyhow::Result<GsUrl> {
"gs" => {
let bucket_name = url.host_str().context("no bucket specified")?;
// Skip first /
let object_name = &url.path()[1..];
let object_name = if url.path().is_empty() {
""
} else {
&url.path()[1..]
};

Ok(GsUrl {
bucket_name: tame_gcs::BucketName::try_from(String::from(bucket_name))?,
Expand Down