Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[README] Fix Sound Effect Feedback Documentation #64

Merged
merged 2 commits into from
Apr 6, 2024
Merged

[README] Fix Sound Effect Feedback Documentation #64

merged 2 commits into from
Apr 6, 2024

Conversation

nickkohrn
Copy link
Contributor

Just a super-small fix for the README documentation of Sound Effect Feedback

Copy link
Collaborator

@mergesort mergesort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nickkohrn, thanks for the contribution and for trying to help Pow!

I think the original version is slightly clearer, but I also don't think is easy to parse. What do you think of this rewrite to ensure maximum clarity?

This effect will not interrupt or duck any other audio that may currently playing. This effect is not guaranteed to be triggered, the effect running depends on the user's silent switch position and the current playback device.

@nickkohrn
Copy link
Contributor Author

👋 Hey @mergesort,

I think your suggestion is better, thanks!

There's just one small fix for "may currently playing":

This effect will not interrupt or duck any other audio that may be currently playing. This effect is not guaranteed to be triggered, the effect running depends on the user's silent switch position and the current playback device.

If that works, then I'll push up the change.

Edit documentation, based on feedback from @mergesort
@mergesort
Copy link
Collaborator

Seems great to me, will merge this in. Thanks a lot Nick!

@mergesort mergesort merged commit ebf05a2 into EmergeTools:main Apr 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants