Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Analytics notice and settings component #2568

Merged
merged 13 commits into from
Aug 2, 2023
Merged

chore: Analytics notice and settings component #2568

merged 13 commits into from
Aug 2, 2023

Conversation

jorbuedo
Copy link
Contributor

@jorbuedo jorbuedo commented Aug 1, 2023 •
edited
Loading

@jorbuedo jorbuedo requested a review from banklesss August 1, 2023 11:28
@jorbuedo jorbuedo self-assigned this Aug 1, 2023
@jorbuedo jorbuedo changed the title Adds bare bones analytics notice Adds analytics notice and settings component Aug 1, 2023
@jorbuedo jorbuedo added the wip Shows that a PR shouldn't be merge label Aug 1, 2023
@jorbuedo jorbuedo changed the title Adds analytics notice and settings component [WIP] Adds analytics notice and settings component Aug 1, 2023
@stackchain stackchain added this to the 4.20.0 milestone Aug 1, 2023
@stackchain
Copy link
Member

relates to #2568 - for settings

@jorbuedo jorbuedo force-pushed the yomo-657-analytics-warning branch from f243337 to 4e82bd5 Compare August 1, 2023 13:58
@jorbuedo jorbuedo removed wip Shows that a PR shouldn't be merge dont-merge labels Aug 1, 2023
@jorbuedo jorbuedo marked this pull request as ready for review August 1, 2023 14:06
@jorbuedo jorbuedo changed the title [WIP] Adds analytics notice and settings component Adds analytics notice and settings component Aug 1, 2023
@jorbuedo
Copy link
Contributor Author

jorbuedo commented Aug 1, 2023

@stackchain Do we add at least the English translation manually into the locales json, or leave it for the translation tool?
The manage-translations script creates a lot of changes not related to these new lines.

@stackchain
Copy link
Member

@stackchain Do we add at least the English translation manually into the locales json, or leave it for the translation tool?
The manage-translations script creates a lot of changes not related to these new lines.

We add for the base en-US.json and CrowdIn ping the translators and open the PRs automatically, so yes, we add for en-US, make sure to don't update any other language cuz this will unsynch crowdin.

@stackchain stackchain force-pushed the yomo-657-analytics-warning branch from 2a48844 to c5665a5 Compare August 1, 2023 14:21
stackchain and others added 3 commits August 2, 2023 08:28
@stackchain
Update apps/wallet-mobile/src/components/Analytics/Analytics.tsx
23ec2b5 
Signed-off-by: Juliano Lazzarotto <30806844+stackchain@users.noreply.github.com>
@stackchain
Update apps/wallet-mobile/src/i18n/locales/en-US.json
21791b0 
Signed-off-by: Juliano Lazzarotto <30806844+stackchain@users.noreply.github.com>
@jorbuedo
Remove margins
1f9d96f
stackchain
stackchain reviewed Aug 2, 2023
View reviewed changes
apps/wallet-mobile/src/components/Analytics/Analytics.tsx
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we have the both stories? notice and settings, then I think we are g2g

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The component has the stories for both. Not their containers though.

@stackchain stackchain changed the title Adds analytics notice and settings component chore: Analytics notice and settings component Aug 2, 2023
@stackchain stackchain merged commit d26bc38 into develop Aug 2, 2023
@stackchain stackchain deleted the yomo-657-analytics-warning branch August 2, 2023 15:32
@stackchain stackchain mentioned this pull request Aug 15, 2023
Merged
71 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@banklesss banklesss banklesss left review comments

@stackchain stackchain stackchain left review comments

Assignees

@jorbuedo jorbuedo

Labels
feature
Projects
None yet
Milestone
4.20.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jorbuedo @stackchain @banklesss