chore: add sign and submit with passwoard #2663
Conversation
|
This one is still WIP, right? |
Hi, yes! but the flow related to the sign and submit with password is almost ready |
…e/sign-and-submit-tx
SorinC6
added
help wanted
SorinC6
removed
help wanted
|
@SorinC6 What's the status? What help do you need? Is it about the backend error? |
There was a problem hiding this comment.
Hello, I've noticed that when I try to place a limit order, the button is unresponsive. I've noticed the warning [Error: Protocol needs to be one of [minswap, wingriders, sundaeswap, muesliswap, muesliswap_v2]] in console, so maybe it's related. I've tried to Swap 1 ADA for 3,333,333,333 HOSKY at the limit price 0.0000000003
Following yesterday's conversation. I don't think we have any protocol validation on the app. So I assume this error came from the backend? |
yeah, seems like for |
| @@ -907,6 +909,7 @@ export const makeShelleyWallet = (constants: typeof MAINNET | typeof TESTNET) => | |||
| } | |||
|
|
|||
| async submitTransaction(signedTx: string) { | |||
| console.log('submitTransaction signedTx', signedTx) | |||
There was a problem hiding this comment.
| console.log('submitTransaction signedTx', signedTx) | |
| console.log('submitTransaction signedTx', signedTx) |
| @@ -621,7 +621,7 @@ export const makeShelleyWallet = (constants: typeof MAINNET | typeof TESTNET) => | |||
| } | |||
| } | |||
|
|
|||
| async signTx(unsignedTx: YoroiUnsignedTx, decryptedMasterKey: string) { | |||
| async signTx(unsignedTx: YoroiUnsignedTx, decryptedMasterKey: string, datum?: any) { | |||
There was a problem hiding this comment.
update the type (ShelleyWallet + ByronWallet)
| @@ -420,6 +421,7 @@ export const useSignWithHwAndSubmitTx = ( | |||
| ...options?.signTx, | |||
| onSuccess: (signedTx, args, context) => { | |||
| options?.signTx?.onSuccess?.(signedTx, args, context) | |||
| console.log('useSignWithHwAndSubmitTx', {signedTx, args, context}) | |||
There was a problem hiding this comment.
| console.log('useSignWithHwAndSubmitTx', {signedTx, args, context}) | |
| console.log('useSignWithHwAndSubmitTx', {signedTx, args, context}) |
There was a problem hiding this comment.
I've updated it, can you revert, and reapply later if needed?
task: