Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESP32 support. #66

Closed
peterj43 opened this issue May 27, 2020 · 2 comments
Closed

ESP32 support. #66

peterj43 opened this issue May 27, 2020 · 2 comments

Comments

@peterj43
Copy link
Contributor

I have made changes to SDI-12 driver to support the ESP32. Is this a development you would like to see push back in to the repo?
@SRGDamia1
Copy link
Contributor

Yes. Please submit a PR.

peterj43 added a commit to peterj43/Arduino-SDI-12 that referenced this issue May 29, 2020
@peterj43
[Issue EnviroDIY#66]ESP32/8266 Has a micro second free running timer …
8bb4f1f 
…so we have

no need to configurea time for these.
 1. Change the names to the states  proefixing them with SDI12_ to
eliminate confilct with ESP hall files .
 2. Created a new READTIME macro  to replace  TCNTX this id defined  in
SDI12.h This helps to reduce the conditional platform specific code from
the main driver files.
 3. Introduced a typedef conditional on platform for the READ TIME
value.
SRGDamia1 added a commit that referenced this issue Jul 2, 2020
@SRGDamia1
Merge pull request #68 from peterj43/Add-ESP32-Support
b428a55 
[Issue #66]ESP32/8266 implementation
@SRGDamia1
Copy link
Contributor

This was implemented and tested a while ago; closing this old issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SRGDamia1 @peterj43