You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Has a micro second free running timer so we have no need to configurea time for these.
Change the names to the states proefixing them with SDI12_ to
eliminate confilct with ESP hall files .
Created a new READTIME macro to replace TCNTX this id defined in
SDI12.h This helps to reduce the conditional platform specific code from
the main driver files.
Introduced a typedef conditional on platform for the READ TIME
value.
…so we have
no need to configurea time for these.
1. Change the names to the states proefixing them with SDI12_ to
eliminate confilct with ESP hall files .
2. Created a new READTIME macro to replace TCNTX this id defined in
SDI12.h This helps to reduce the conditional platform specific code from
the main driver files.
3. Introduced a typedef conditional on platform for the READ TIME
value.
I have an implementation that seems to be working it's just waiting for further review.
By the way, I have a sensor that uses SDI-12. What version of the library do I have to download to test it on the ESP32?
All you need is this master of this project and that now includes support for ESP32.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Has a micro second free running timer so we have no need to configurea time for these.
eliminate confilct with ESP hall files .
SDI12.h This helps to reduce the conditional platform specific code from
the main driver files.
value.