Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring Checker statistics page #1686

Merged
merged 1 commit into from
Sep 7, 2018

Conversation

csordasmarton
Copy link
Contributor

Closes #1684

Add Detection status, Review status and Severity level filters to the statistics page.

Copy link
Contributor

@gyorb gyorb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should discuss this feature a bit more. Review status filtering can produce some interesting results.

All reports 14
unreviewed 4
confirmed 10
intentional 1

deadcode.DeadStores |   | 14 |   | 4 | 10 |   | 1

Actually there are 15 results but because the intentional filter is turned off the all reports column count will be counted by that filter even if the table shows the review status for all the reports.

@dkrupp
Copy link
Member

dkrupp commented Sep 3, 2018

We should not make selectable for a filter that is represented in a column.
So I think we should introduce the detection status filter with default value: new, reopened, unresolved and remove the "resolved" column from the table.

@gyorb gyorb modified the milestones: release 6.8, release 6.8.1 Sep 3, 2018
@dkrupp dkrupp added this to the release 6.8 milestone Sep 6, 2018
@dkrupp dkrupp self-requested a review September 6, 2018 08:55
Copy link
Member

@dkrupp dkrupp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the Resolved column and add a new "detection status filter".
As a general rule of thumb, do not add a filter, which has a column in the table.

So do not add review status filter.

@@ -0,0 +1,54 @@
// -------------------------------------------------------------------------
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not add the review status filter as it appears as column in the statistics table.

Remove the "Resolved" column from the table and add the "detection status" as a filter among the filters.
This way one can show the distribution of the review status for the "currently outstanding" or for the "fixed bugs".

@gyorb gyorb removed this from the release 6.8 milestone Sep 6, 2018
* Add Detection status and Severity level filters to the
statistics page.
* Remove Resolved reports column from the Checker statistics table.
* Place All reports column to the end of Checker statistics table.
@csordasmarton csordasmarton force-pushed the ui-statistics-more-filter branch from 10dbd4c to 7d56fab Compare September 7, 2018 08:26
@csordasmarton csordasmarton changed the title Add more checker statistics filter Refactoring Checker statistics page Sep 7, 2018
@gyorb gyorb merged commit 654472f into Ericsson:master Sep 7, 2018
@csordasmarton csordasmarton deleted the ui-statistics-more-filter branch September 11, 2018 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants