-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring Checker statistics page #1686
Conversation
937fd06
to
10dbd4c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should discuss this feature a bit more. Review status filtering can produce some interesting results.
All reports 14
unreviewed 4
confirmed 10
intentional 1
deadcode.DeadStores | | 14 | | 4 | 10 | | 1
Actually there are 15 results but because the intentional filter is turned off the all reports column count will be counted by that filter even if the table shows the review status for all the reports.
We should not make selectable for a filter that is represented in a column. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the Resolved column and add a new "detection status filter".
As a general rule of thumb, do not add a filter, which has a column in the table.
So do not add review status filter.
@@ -0,0 +1,54 @@ | |||
// ------------------------------------------------------------------------- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not add the review status filter as it appears as column in the statistics table.
Remove the "Resolved" column from the table and add the "detection status" as a filter among the filters.
This way one can show the distribution of the review status for the "currently outstanding" or for the "fixed bugs".
* Add Detection status and Severity level filters to the statistics page. * Remove Resolved reports column from the Checker statistics table. * Place All reports column to the end of Checker statistics table.
10dbd4c
to
7d56fab
Compare
Add
Detection status
,Review status
andSeverity level
filters to the statistics page.