-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring Checker statistics page #1686
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
54 changes: 54 additions & 0 deletions
54
www/scripts/codecheckerviewer/filter/ReviewStatusFilter.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| // ------------------------------------------------------------------------- | ||
| // The CodeChecker Infrastructure | ||
| // This file is distributed under the University of Illinois Open Source | ||
| // License. See LICENSE.TXT for details. | ||
| // ------------------------------------------------------------------------- | ||
|
|
||
| define([ | ||
| 'dojo/_base/declare', | ||
| 'dojo/Deferred', | ||
| 'codechecker/filter/SelectFilter', | ||
| 'codechecker/util'], | ||
| function (declare, Deferred, SelectFilter, util) { | ||
| return declare(SelectFilter, { | ||
| stateConverter : function (value) { | ||
| var status = util.enumValueToKey( | ||
| CC_OBJECTS.ReviewStatus, parseInt(value)).replace('_', ' '); | ||
| return status.charAt(0).toUpperCase() + status.slice(1).toLowerCase(); | ||
| }, | ||
| stateDecoder : function (key) { | ||
| return CC_OBJECTS.ReviewStatus[key.replace(' ', '_').toUpperCase()]; | ||
| }, | ||
| defaultValues : function () { | ||
| var state = {}; | ||
| state[this.class] = [ | ||
| CC_OBJECTS.ReviewStatus.UNREVIEWED, | ||
| CC_OBJECTS.ReviewStatus.CONFIRMED | ||
| ].map(this.stateConverter); | ||
|
|
||
| return state; | ||
| }, | ||
| getIconClass : function (value) { | ||
| var statusCode = this.stateDecoder(value); | ||
| return 'customIcon ' + util.reviewStatusCssClass(statusCode); | ||
| }, | ||
| getItems : function (opt) { | ||
| opt = this.parent.initReportFilterOptions(opt); | ||
| opt.reportFilter.reviewStatus = null; | ||
|
|
||
| var deferred = new Deferred(); | ||
| CC_SERVICE.getReviewStatusCounts(opt.runIds, opt.reportFilter, | ||
| opt.cmpData, function (res) { | ||
| deferred.resolve(Object.keys(CC_OBJECTS.ReviewStatus).map( | ||
| function (key) { | ||
| var value = CC_OBJECTS.ReviewStatus[key]; | ||
| return { | ||
| value : util.reviewStatusFromCodeToString(value), | ||
| count : res[value] !== undefined ? res[value] : 0 | ||
| }; | ||
| })); | ||
| }); | ||
| return deferred; | ||
| } | ||
| }); | ||
| }); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| // ------------------------------------------------------------------------- | ||
| // The CodeChecker Infrastructure | ||
| // This file is distributed under the University of Illinois Open Source | ||
| // License. See LICENSE.TXT for details. | ||
| // ------------------------------------------------------------------------- | ||
|
|
||
| define([ | ||
| 'dojo/_base/declare', | ||
| 'dojo/Deferred', | ||
| 'codechecker/filter/SelectFilter', | ||
| 'codechecker/util'], | ||
| function (declare, Deferred, SelectFilter, util) { | ||
| return declare(SelectFilter, { | ||
| stateConverter : function (value) { | ||
| var status = util.enumValueToKey( | ||
| CC_OBJECTS.Severity, parseInt(value)); | ||
| return status.charAt(0).toUpperCase() + status.slice(1).toLowerCase(); | ||
| }, | ||
| stateDecoder : function (key) { | ||
| return CC_OBJECTS.Severity[key.toUpperCase()]; | ||
| }, | ||
| getIconClass : function (value) { | ||
| return 'customIcon icon-severity-' + value.toLowerCase(); | ||
| }, | ||
| getItems : function (opt) { | ||
| opt = this.parent.initReportFilterOptions(opt); | ||
| opt.reportFilter.severity = null; | ||
|
|
||
| var deferred = new Deferred(); | ||
| CC_SERVICE.getSeverityCounts(opt.runIds, opt.reportFilter, | ||
| opt.cmpData, function (res) { | ||
| deferred.resolve(Object.keys(CC_OBJECTS.Severity).sort( | ||
| function (a, b) { | ||
| return CC_OBJECTS.Severity[a] < CC_OBJECTS.Severity[b]; | ||
| }).map(function (key) { | ||
| var value = CC_OBJECTS.Severity[key]; | ||
| return { | ||
| value : key[0] + key.slice(1).toLowerCase(), | ||
| count : res[value] !== undefined ? res[value] : 0 | ||
| }; | ||
| })); | ||
| }); | ||
|
|
||
| return deferred; | ||
| } | ||
| }); | ||
| }); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not add the review status filter as it appears as column in the statistics table.
Remove the "Resolved" column from the table and add the "detection status" as a filter among the filters.
This way one can show the distribution of the review status for the "currently outstanding" or for the "fixed bugs".