Feature/grpc support #40
Conversation
| "port": "80", | ||
| "endpoint": "/end-2", | ||
| "endpoint": "end2", |
There was a problem hiding this comment.
Is there any restriction with special symbols? I guess that's why you had to change their format...
There was a problem hiding this comment.
Yes, for Now I'd suggest to don't use any specific symbols like dashes or underline. We can add the support of these symbols in #25.
| Path string `yaml:"path,omitempty"` | ||
| Port int `yaml:"port,omitempty"` | ||
| } `yaml:"httpGet,omitempty"` | ||
| Exec struct { |
There was a problem hiding this comment.
Is this so you can probe readiness in grpc with your own implemented mechanism?
| @@ -73,14 +82,17 @@ func CreateDeployment(metadataName, selectorAppName, selectorClusterName string, | |||
| func CreateDeploymentWithAffinity(metadataName, selectorAppName, selectorClusterName string, numberOfReplicas int, | |||
There was a problem hiding this comment.
The functions CreateDeployment() and CreateDeploymentWithAffinity() share several lines of similar code... we may consider here how to avoid duplicated code.
There was a problem hiding this comment.
This will be fixed by #41.
| RUN apt update | ||
| RUN apt install -y jq \ | ||
| wget \ | ||
| 2to3 |
There was a problem hiding this comment.
Why do we need a package for translation from python2 to python3?
There was a problem hiding this comment.
In run.sh we uninstall this package. But in general, when we compile the service.proto file with protoc. those generated files have issues with importing each other (it wasn't fixed by adding init.py). The only solution to fix it was to change the import section to something like:
from . import service_pb2
So we need to add from . to imports. The easiest way that I found was using this package.
There was a problem hiding this comment.
Maybe in the future we can fully update the code to python 3...
model/Dockerfile
Outdated
|
|
||
| WORKDIR /usr/src/app | ||
| RUN ls |
There was a problem hiding this comment.
Nope. I'll delete it.
This PR closes #2 .
The procedure for grpc is:
service.protobased on the input json and add it as a configmap value to the service. The reason for not creating a new configmap is due to the restricted permission of configmaps. We also add the related healthcheck based on protocol.2.1. it compiles the
service.protoafter copying the values to the new file with right permissions.2.2. it generates the main application of grpc with filling a template.
2.3. it runs the main application of grpc.
We decided to move all tasks to common folder. The client of grpc is in that folder.
The output of calling the grpc service is: