Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optional nodename for deployment affintiy #41

Conversation

salehsedghpour
Copy link
Collaborator

This PR closes #26

Previously we had two deployment models, one with affinity and one without affinity. Now we have one deployment model, and if the user does not enter the nodename in service description, we won't add an empty string in the generated files.

Example:
If the input json file is like this:

.
.
"services": [
    {
      "name": "service-1",
      "clusters": [
        {
          "cluster": "cluster-1",
          "namespace": "ns-1",
        }
      ],
      "resources": {
.
.
.

Before this PR the output would be like:

spec:
            nodeName: 
            containers:
                - name: app
                  image: app-demo:latest
                  imagePullPolicy: Never

After this PR the output is:

spec:
            containers:
                - name: app
                  image: app-demo:latest
                  imagePullPolicy: Never

@salehsedghpour salehsedghpour requested a review from alekodu March 29, 2022 05:16
Copy link
Member

@alekodu alekodu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good the code was simplified.

@salehsedghpour salehsedghpour merged commit 883a355 into EricssonResearch:main Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify the deployment models
2 participants