Example using VueJS #138
Merged
Example using VueJS #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Working demo with and without popups. Minor tweaks.
|
rock and roll 🎼! it looks like this even resolves #100. |
|
Aside from #11, #100 was in my mind when I was creating this. This type of implementation would require some form of routing framework to work, though. I'm not entirely sure how to pass a session through a redirect like you mentioned. Perhaps a localStorage implementation? I can mess around with that a bit and see what I find. |
|
@patrickarlt Thanks for the feedback on #140, everything makes sense 👍 I'll spend some time in the next couple of days updating this with both your's and @jgravois 's input on this. |
|
i agree. thanks for both your contributions and for commenting your code so thoroughly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wanted to get my feet wet with this lib and thought it would be helpful to contribute in the process. This is a VueJS app that uses the authentication and request packages.
Initial template created with webpack-simple then added on the vue-router plugin to handle the authentication callbacks.