fix(auth): decode username when parsing response from OAuth #166

noahmulfinger · 2018-03-29T23:35:15Z

Usernames with @ symbols are returned from OAuth as %40, so we need to decode them with
decodeURIComponent.

AFFECTS PACKAGES:
@esri/arcgis-rest-auth

ISSUES CLOSED: #165

Usernames with @ symbols are returned from OAuth as %40, so we need to decode them with decodeURIComponent. AFFECTS PACKAGES: @esri/arcgis-rest-auth ISSUES CLOSED: #165

coveralls · 2018-03-29T23:43:07Z

Coverage remained the same at 100.0% when pulling e0c2a44 on fix-165 into 29e879d on master.

jgravois

nice work!

this makes me even more glad that i switched our dummy username to use an @ symbol in #143

fix(auth): decode username when parsing response from OAuth

e0c2a44

Usernames with @ symbols are returned from OAuth as %40, so we need to decode them with decodeURIComponent. AFFECTS PACKAGES: @esri/arcgis-rest-auth ISSUES CLOSED: #165

jgravois approved these changes Mar 30, 2018

View reviewed changes

jgravois merged commit fd9005f into master Mar 30, 2018

jgravois deleted the fix-165 branch March 30, 2018 20:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(auth): decode username when parsing response from OAuth #166

fix(auth): decode username when parsing response from OAuth #166

noahmulfinger commented Mar 29, 2018

coveralls commented Mar 29, 2018 •

edited

Loading

jgravois left a comment

fix(auth): decode username when parsing response from OAuth #166

fix(auth): decode username when parsing response from OAuth #166

Conversation

noahmulfinger commented Mar 29, 2018

coveralls commented Mar 29, 2018 • edited Loading

jgravois left a comment

Choose a reason for hiding this comment

coveralls commented Mar 29, 2018 •

edited

Loading