Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panel: spacing changed as a result of 9730 #9921

Closed
2 of 6 tasks
DitwanP opened this issue Jul 31, 2024 · 2 comments
Closed
2 of 6 tasks

Panel: spacing changed as a result of 9730 #9921

DitwanP opened this issue Jul 31, 2024 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality regression Issues that are caused by changes in a release, but were working before that.
Milestone
2.11.1 patch

Comments

@DitwanP
Copy link
Contributor

DitwanP commented Jul 31, 2024

Check existing issues

Actual Behavior

Looks like the top and bottom padding on header-content was changed from 14px to 12px. This change was not intended for now so we need to revert that back.

Before and after:
panel-padding-change

image
image

Expected Behavior

The header content should retain the same 14px padding as before #9730

Reproduction Sample

https://codepen.io/driskull/pen/qBzrbwM

Reproduction Steps

  1. Open codepen
  2. Inspect header content then note 14px top and bottom padding
  3. change version to 2.11.0 and note the new 12px padding

Reproduction Version

2.11.0

Relevant Info

No response

Regression?

2.10.1

Priority impact

impact - p1 - need for current milestone

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Maps SDK for JavaScript
@DitwanP DitwanP added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. regression Issues that are caused by changes in a release, but were working before that. labels Jul 31, 2024
@github-actions github-actions bot added ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. calcite-components Issues specific to the @esri/calcite-components package. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone labels Jul 31, 2024
@DitwanP DitwanP added estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. p - high Issue should be addressed in the current milestone, impacts component or core functionality labels Jul 31, 2024
@geospatialem geospatialem added this to the 2.11.1 patch milestone Jul 31, 2024
@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label Jul 31, 2024
@jcfranco jcfranco self-assigned this Aug 1, 2024
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Aug 1, 2024
@jcfranco jcfranco mentioned this issue Aug 1, 2024
Merged
jcfranco added a commit that referenced this issue Aug 1, 2024
@jcfranco
fix(panel, flow-item): fix header padding regression (#9936)
f618380 
**Related Issue:** #9921

## Summary

Fix unintentional header padding adjustment for medium/default scale.
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Aug 1, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned jcfranco Aug 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 1, 2024

Installed and assigned for verification.

@DitwanP
Copy link
Contributor Author

DitwanP commented Aug 1, 2024

🍡 Verified locally on dev

New vertical padding var:
Screenshot 2024-08-01 at 3 23 46 PM

Padding:
image

@DitwanP DitwanP closed this as completed Aug 1, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Aug 1, 2024
benelan pushed a commit that referenced this issue Aug 2, 2024
@jcfranco @benelan
fix(panel, flow-item): fix header padding regression (#9936)
a43ee46 
**Related Issue:** #9921

## Summary

Fix unintentional header padding adjustment for medium/default scale.
benelan pushed a commit that referenced this issue Aug 2, 2024
@jcfranco @benelan
fix(panel, flow-item): fix header padding regression (#9936)
90e9368 
**Related Issue:** #9921

## Summary

Fix unintentional header padding adjustment for medium/default scale.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality regression Issues that are caused by changes in a release, but were working before that.
Projects
None yet
Milestone
2.11.1 patch
Development

No branches or pull requests
3 participants
@jcfranco @geospatialem @DitwanP