Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(panel, flow-item): fix header padding regression #9936

Merged
merged 2 commits into from
Aug 1, 2024
Merged

fix(panel, flow-item): fix header padding regression #9936

merged 2 commits into from
Aug 1, 2024

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Aug 1, 2024

Related Issue: #9921

Summary

Fix unintentional header padding adjustment for medium/default scale.

@jcfranco jcfranco added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Aug 1, 2024
@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Aug 1, 2024
@jcfranco jcfranco requested a review from ashetland August 1, 2024 17:42
@jcfranco jcfranco marked this pull request as ready for review August 1, 2024 19:24
driskull
driskull reviewed Aug 1, 2024
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that the original padding styles are coming from the include here: @import "../../assets/styles/header";

https://github.com/Esri/calcite-design-system/blob/dev/packages/calcite-components/src/assets/styles/_header.scss

I wonder if we should just remove importing this and handle the padding all in one file?

@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Aug 1, 2024
@jcfranco
Copy link
Member Author

jcfranco commented Aug 1, 2024

@driskull Possibly. We could look at refactoring that this year.

driskull
driskull approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good. 👍

ashetland
ashetland approved these changes Aug 1, 2024
View reviewed changes
Copy link

@ashetland ashetland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹✨

@jcfranco jcfranco merged commit f618380 into dev Aug 1, 2024
13 of 16 checks passed
@jcfranco jcfranco deleted the jcfranco/9921-fix-panel-header-spacing-regression branch August 1, 2024 21:46
@github-actions github-actions bot added this to the 2.11.1 patch milestone Aug 1, 2024
benelan pushed a commit that referenced this pull request Aug 2, 2024
@jcfranco @benelan
fix(panel, flow-item): fix header padding regression (#9936)
a43ee46 
**Related Issue:** #9921

## Summary

Fix unintentional header padding adjustment for medium/default scale.
@benelan benelan mentioned this pull request Aug 2, 2024
Merged
benelan pushed a commit that referenced this pull request Aug 2, 2024
@jcfranco @benelan
fix(panel, flow-item): fix header padding regression (#9936)
90e9368 
**Related Issue:** #9921

## Summary

Fix unintentional header padding adjustment for medium/default scale.
@calcite-admin calcite-admin mentioned this pull request Aug 2, 2024
Merged
benelan pushed a commit that referenced this pull request Aug 2, 2024
@calcite-admin
chore: release main (#9952)
59c91c9 
🤖 I have created a release *beep* *boop*
---


<details><summary>@esri/calcite-components: 2.11.1</summary>

##
[2.11.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.11.0...@esri/calcite-components@2.11.1)
(2024-08-02)


### Bug Fixes

* **block:** Display correct header spacing when heading or description
are present
([#9924](#9924))
([d8f1077](d8f1077))
* **panel, flow-item:** Fix header padding regression
([#9936](#9936))
([90e9368](90e9368))
</details>

<details><summary>@esri/calcite-components-angular: 2.11.1</summary>

##
[2.11.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.11.0...@esri/calcite-components-angular@2.11.1)
(2024-08-02)


### Miscellaneous Chores

* **@esri/calcite-components-angular:** Synchronize components versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from ^2.11.0 to ^2.11.1
</details>

<details><summary>@esri/calcite-components-react: 2.11.1</summary>

##
[2.11.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.11.0...@esri/calcite-components-react@2.11.1)
(2024-08-02)


### Miscellaneous Chores

* **@esri/calcite-components-react:** Synchronize components versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from ^2.11.0 to ^2.11.1
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
benelan pushed a commit that referenced this pull request Aug 2, 2024
@calcite-admin @benelan
chore: release main (#9952)
508ebf7 
🤖 I have created a release *beep* *boop*
---

<details><summary>@esri/calcite-components: 2.11.1</summary>

[2.11.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.11.0...@esri/calcite-components@2.11.1)
(2024-08-02)

* **block:** Display correct header spacing when heading or description
are present
([#9924](#9924))
([d8f1077](d8f1077))
* **panel, flow-item:** Fix header padding regression
([#9936](#9936))
([90e9368](90e9368))
</details>

<details><summary>@esri/calcite-components-angular: 2.11.1</summary>

[2.11.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.11.0...@esri/calcite-components-angular@2.11.1)
(2024-08-02)

* **@esri/calcite-components-angular:** Synchronize components versions

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from ^2.11.0 to ^2.11.1
</details>

<details><summary>@esri/calcite-components-react: 2.11.1</summary>

[2.11.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.11.0...@esri/calcite-components-react@2.11.1)
(2024-08-02)

* **@esri/calcite-components-react:** Synchronize components versions

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from ^2.11.0 to ^2.11.1
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
@benelan benelan mentioned this pull request Aug 2, 2024
Merged
benelan added a commit that referenced this pull request Aug 2, 2024
@benelan @calcite-admin
chore: release main (#9952) (#9954)
814041c 
**Related Issue:** #9952

## Summary

Cherry-pick the release commit from `main`.

---

<details><summary>@esri/calcite-components: 2.11.1</summary>


[2.11.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.11.0...@esri/calcite-components@2.11.1)
(2024-08-02)

* **block:** Display correct header spacing when heading or description
are present
([#9924](#9924))

([d8f1077](d8f1077))
* **panel, flow-item:** Fix header padding regression
([#9936](#9936))

([90e9368](90e9368))
</details>

<details><summary>@esri/calcite-components-angular: 2.11.1</summary>


[2.11.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.11.0...@esri/calcite-components-angular@2.11.1)
(2024-08-02)

* **@esri/calcite-components-angular:** Synchronize components versions

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from ^2.11.0 to ^2.11.1
</details>

<details><summary>@esri/calcite-components-react: 2.11.1</summary>


[2.11.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.11.0...@esri/calcite-components-react@2.11.1)
(2024-08-02)

* **@esri/calcite-components-react:** Synchronize components versions

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from ^2.11.0 to ^2.11.1
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See

[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: Calcite Admin <calcite-admin@esri.com>
@benelan benelan mentioned this pull request Aug 28, 2024
Merged
@calcite-admin calcite-admin mentioned this pull request Sep 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashetland ashetland ashetland approved these changes

@driskull driskull driskull approved these changes

@alisonailea alisonailea Awaiting requested review from alisonailea

Assignees

@jcfranco jcfranco

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Milestone
2.11.1 patch
Development

Successfully merging this pull request may close these issues.
3 participants
@jcfranco @driskull @ashetland