Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(docs): generate docs-json for afd usage #5748

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

benelan
Copy link
Member

@benelan benelan commented Nov 14, 2022

Related Issue: #5654

Summary

Turns out adding --no-docs to the build prevents the docs-json output target from being created. The reason I added it was the annoying readmes being generated for each component. The git restore I added to postbuild resolves that, while still generating docs-json.

@benelan benelan requested a review from a team as a code owner November 14, 2022 21:58
@github-actions github-actions bot added the chore Issues with changes that don't modify src or test files. label Nov 14, 2022
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@benelan benelan merged commit d48394e into master Nov 14, 2022
@benelan benelan deleted the benelan/fix-missing-docs-json branch November 14, 2022 22:16
benelan added a commit that referenced this pull request Nov 16, 2022
* master: (24 commits)
  1.0.0-next.632
  feat(pick-list, value-list): Add calciteListFilter event, filteredItems prop, filterText prop and filteredData prop. (#5681)
  fix(block, date-picker, list-item-group, panel, pick-list-group, popover, tip, tip-manager)!: Set default internal heading to a div. (#5728)
  refactor(modal): Update modal to use focus-trap module. (#5676)
  1.0.0-next.631
  fix(input-date-picker): restores mouse clicks on date-picker popup (#5760)
  build(deps): bump loader-utils from 1.4.1 to 1.4.2 (#5764)
  ci(product-label): fix version syntax and use os agnostic newline char (#5762)
  1.0.0-next.630
  ci(pr-bot): don't label dependabot PRs (#5759)
  build(deps): bump chromatic from 6.7.1 to 6.11.4 (#5756)
  fix(combobox): Wrap and break text on long items (#5672)
  build(deps): bump @storybook/addon-interactions from 6.5.9 to 6.5.13 (#5753)
  build(deps): bump type-fest from 3.1.0 to 3.2.0 (#5752)
  build(deps): bump @storybook/addon-a11y from 6.5.12 to 6.5.13 (#5754)
  build(deps): bump postcss from 8.4.18 to 8.4.19 (#5755)
  ci: add chromatic (#5733)
  build(docs): generate docs-json for afd usage (#5748)
  1.0.0-next.629
  fix(inline-editable): Add text-ellipsis when not editing (#5679)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issues with changes that don't modify src or test files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants