Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(input-date-picker): restores mouse clicks on date-picker popup #5760

Merged
merged 6 commits into from
Nov 16, 2022
Merged

fix(input-date-picker): restores mouse clicks on date-picker popup #5760

merged 6 commits into from
Nov 16, 2022

Conversation

eriklharper
Copy link
Contributor

@eriklharper eriklharper commented Nov 15, 2022 •
edited
Loading

Related Issue: #5757

Summary

This fixes an issue where mouse clicks don't register anywhere in the date-picker popup UI.

Workaround:

 <script>
    (async () => {
      await customElements.whenDefined("calcite-input-date-picker");
      const inputDatePicker = document.querySelector("calcite-input-date-picker");
      await inputDatePicker.componentOnReady();

      var style = document.createElement("style");
      style.innerHTML = ".menu-container { pointer-events: inherit !important; }";

      inputDatePicker.shadowRoot.appendChild(style);
    })();
  </script>

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Nov 15, 2022
@eriklharper eriklharper marked this pull request as ready for review November 15, 2022 18:58
@eriklharper eriklharper requested a review from a team as a code owner November 15, 2022 18:58
@eriklharper eriklharper requested a review from jcfranco November 15, 2022 18:58
jcfranco
jcfranco approved these changes Nov 15, 2022
View reviewed changes
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice!

@driskull Any suggestions for additional things to test?

src/components/input-date-picker/input-date-picker.e2e.ts Outdated Show resolved Hide resolved
@eriklharper eriklharper changed the title fix(input-date-picker): restores clicks on date-picker popup fix(input-date-picker): restores mouse clicks on date-picker popup Nov 15, 2022
@jcfranco
Copy link
Member

cc @AdelheidF

@eriklharper
test review changes
4e2fb85
@eriklharper
Merge branch 'eriklharper/5757-cant-click-date-picker-popup' of githu…
72f44b6 
…b.com:Esri/calcite-components into eriklharper/5757-cant-click-date-picker-popup
@eriklharper eriklharper added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Nov 15, 2022
@eriklharper eriklharper added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Nov 15, 2022
@eriklharper eriklharper merged commit 98f28c6 into master Nov 16, 2022
@eriklharper eriklharper deleted the eriklharper/5757-cant-click-date-picker-popup branch November 16, 2022 00:22
benelan added a commit that referenced this pull request Nov 16, 2022
@benelan
Merge branch 'master' into benelan/cleanup-big-decimal
7c3445e 
* master: (24 commits)
  1.0.0-next.632
  feat(pick-list, value-list): Add calciteListFilter event, filteredItems prop, filterText prop and filteredData prop. (#5681)
  fix(block, date-picker, list-item-group, panel, pick-list-group, popover, tip, tip-manager)!: Set default internal heading to a div. (#5728)
  refactor(modal): Update modal to use focus-trap module. (#5676)
  1.0.0-next.631
  fix(input-date-picker): restores mouse clicks on date-picker popup (#5760)
  build(deps): bump loader-utils from 1.4.1 to 1.4.2 (#5764)
  ci(product-label): fix version syntax and use os agnostic newline char (#5762)
  1.0.0-next.630
  ci(pr-bot): don't label dependabot PRs (#5759)
  build(deps): bump chromatic from 6.7.1 to 6.11.4 (#5756)
  fix(combobox): Wrap and break text on long items (#5672)
  build(deps): bump @storybook/addon-interactions from 6.5.9 to 6.5.13 (#5753)
  build(deps): bump type-fest from 3.1.0 to 3.2.0 (#5752)
  build(deps): bump @storybook/addon-a11y from 6.5.12 to 6.5.13 (#5754)
  build(deps): bump postcss from 8.4.18 to 8.4.19 (#5755)
  ci: add chromatic (#5733)
  build(docs): generate docs-json for afd usage (#5748)
  1.0.0-next.629
  fix(inline-editable): Add text-ellipsis when not editing (#5679)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdelheidF AdelheidF AdelheidF left review comments

@driskull driskull driskull left review comments

@jcfranco jcfranco jcfranco approved these changes

Assignees

@eriklharper eriklharper

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Milestone
Sprint 2022/11/07 - 2022/11/18
Development

Successfully merging this pull request may close these issues.
4 participants
@eriklharper @jcfranco @driskull @AdelheidF