Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tree-item): reverses regression to bring back focus when navigating with keyboard #6424

Merged

Conversation

Elijbet
Copy link
Contributor

@Elijbet Elijbet commented Feb 6, 2023

Related Issue: #6376

Summary

Reverses regression to bring back focus when navigating with the keyboard and a small cleanup on the existing code.

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Feb 6, 2023
@Elijbet Elijbet marked this pull request as ready for review February 6, 2023 07:12
@Elijbet Elijbet requested a review from a team as a code owner February 6, 2023 07:12
@Elijbet Elijbet added pr ready for visual snapshots Adding this label will run visual snapshot testing. regression Issues that are caused by changes in a release, but were working before that. labels Feb 6, 2023
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than a question that could lead to simplification, this LGTM!

src/components/tree-item/tree-item.scss Outdated Show resolved Hide resolved
@Elijbet Elijbet added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Feb 6, 2023
@Elijbet Elijbet merged commit ea9d403 into master Feb 6, 2023
@Elijbet Elijbet deleted the elijbet/6376-focus-present-when-navigating-via-keyboard branch February 6, 2023 19:40
benelan added a commit that referenced this pull request Feb 8, 2023
…c-rulez

* origin/master:
  docs: update component READMEs (#6352)
  ci(next): fix commit message (#6425)
  fix(vite): resolve lazying loading error in dist build (#6436)
  docs(changelog): remove reverted feature (#6435)
  revert: "feat(pagination, split-button, dropdown, date-picker) action-group): add setFocus method (#6405)" (#6426)
  1.1.0-next.2
  docs(segmented-control): update event description for calciteSegmentedControlChange (#6428)
  fix(tree-item): reverses regression to bring back focus when navigating with keyboard (#6424)
  fix(icon): fix icon normalization to handle x-times-named icons (#6422)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. pr ready for visual snapshots Adding this label will run visual snapshot testing. regression Issues that are caused by changes in a release, but were working before that.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants