Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(next): fix commit message #6425

Merged
merged 3 commits into from
Feb 8, 2023
Merged

Conversation

benelan
Copy link
Member

@benelan benelan commented Feb 6, 2023

Related Issue: #6406

Summary

The commit messages for next releases are goofed. This removes our custom {{currentTag}} commit message and replaces it with the default: chore(release): {{currentTag}}.

It also removes noVerify so we can remove npm run lint:md because it will be done by lint-staged.

The commit message was fine before the PR linked above. No idea why this is happening but it's probably a standard-version bug

@benelan benelan requested a review from a team as a code owner February 6, 2023 21:25
@github-actions github-actions bot added the chore Issues with changes that don't modify src or test files. label Feb 6, 2023
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@benelan benelan merged commit 431b118 into master Feb 8, 2023
@benelan benelan deleted the benelan/fix-next-commit-message branch February 8, 2023 02:42
benelan added a commit that referenced this pull request Feb 8, 2023
…c-rulez

* origin/master:
  docs: update component READMEs (#6352)
  ci(next): fix commit message (#6425)
  fix(vite): resolve lazying loading error in dist build (#6436)
  docs(changelog): remove reverted feature (#6435)
  revert: "feat(pagination, split-button, dropdown, date-picker) action-group): add setFocus method (#6405)" (#6426)
  1.1.0-next.2
  docs(segmented-control): update event description for calciteSegmentedControlChange (#6428)
  fix(tree-item): reverses regression to bring back focus when navigating with keyboard (#6424)
  fix(icon): fix icon normalization to handle x-times-named icons (#6422)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issues with changes that don't modify src or test files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants