Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(panel, flow-item): fix missing scale property in interface #9762

Conversation

DitwanP
Copy link
Contributor

@DitwanP DitwanP commented Jul 12, 2024

Related Issue: #6980

Summary

I missed adding the scale property to the interface so there was a TS error. The error wasn't present for me until I relaunched my IDE. This PR is to fix that error.

@DitwanP DitwanP added testing Issues related to automated or manual testing. pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Jul 12, 2024
@DitwanP DitwanP marked this pull request as ready for review July 12, 2024 16:54
@DitwanP DitwanP requested a review from a team as a code owner July 12, 2024 16:54
@DitwanP DitwanP requested a review from driskull July 12, 2024 16:54
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

DitwanP added 3 commits July 12, 2024 11:18
…nto dit13711/fix-missing-scale-property-in-story-for-flowItem-and-panel
…nto dit13711/fix-missing-scale-property-in-story-for-flowItem-and-panel
@DitwanP DitwanP removed the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Jul 16, 2024
@DitwanP DitwanP added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Jul 16, 2024
@DitwanP DitwanP closed this Jul 16, 2024
@DitwanP DitwanP deleted the dit13711/fix-missing-scale-property-in-story-for-flowItem-and-panel branch July 16, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Issues related to automated or manual testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants