Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Panel and Flow Item] Add scale property #6980

Closed
asangma opened this issue May 18, 2023 · 8 comments
Closed

[Panel and Flow Item] Add scale property #6980

asangma opened this issue May 18, 2023 · 8 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 5 A few days of work, definitely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - high Issue should be addressed in the current milestone, impacts component or core functionality ready for dev Issues ready for development implementation.
Milestone
2024-07-31 - Jul ...

Comments

@asangma
Copy link
Contributor

asangma commented May 18, 2023 •
edited by SkyeSeitz
Loading

Description

Add a scale property to Panel.
Popover has scale, and it is helpful. But there are times when a flow needs to happen in a Popover and in a compact space.

image

Acceptance Criteria

Utilize existing scaling conventions.
Work in Popover.
Work in ShellPanel.
In accordance with issue #7623

Relevant Info

A dependency needed for the Dialog + Modal component effort in #7886
See Figma file for specs
image

Which Component

Panel and FlowItem

Example Use Case

When a flow needs to happen in a compact space...especially in a Popover. See image above.

Priority impact

p4 - not time sensitive

Esri team

N/A
@asangma asangma added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels May 18, 2023
@github-actions github-actions bot added the impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive label May 18, 2023
@macandcheese
Copy link
Contributor

What would adjust with scale? Rendered text and padding? If so, may want to address Block as well as it would be used within these and may end up with mismatched text sizes and alignment.

@asangma
Copy link
Contributor Author

asangma commented Jun 5, 2023

@macandcheese Good point.

For Panel and FlowItem, I would say font-size and padding.

And for Block, I'm thinking since it is currently at 14px, we could match Button's font-sizes.

@geospatialem geospatialem mentioned this issue Jun 15, 2023
Open
8 tasks
@geospatialem geospatialem added this to the Design Backlog milestone Jun 15, 2023
@geospatialem geospatialem added p - medium Issue is non core or affecting less that 60% of people using the library and removed needs triage Planning workflow - pending design/dev review. labels Jun 15, 2023
@geospatialem geospatialem mentioned this issue Mar 21, 2024
Closed
9 tasks
@brittneytewks brittneytewks removed this from the Design Backlog milestone Apr 1, 2024
@brittneytewks brittneytewks added the design Issues that need design consultation prior to development. label Apr 1, 2024
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Apr 15, 2024
@SkyeSeitz SkyeSeitz mentioned this issue Apr 25, 2024
Open
14 tasks
@SkyeSeitz SkyeSeitz added the ready for dev Issues ready for development implementation. label Apr 30, 2024
@SkyeSeitz SkyeSeitz removed their assignment Apr 30, 2024
@github-actions github-actions bot added 0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Apr 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

cc @geospatialem, @brittneytewks

@SkyeSeitz SkyeSeitz changed the title Panel and FlowItem. Add scale property [Panel and FlowItem] Add scale property May 13, 2024
@DitwanP DitwanP changed the title [Panel and FlowItem] Add scale property [Panel and Flow Item] Add scale property May 13, 2024
@ashetland ashetland mentioned this issue Jun 10, 2024
Open
6 tasks
@geospatialem geospatialem added this to the 2024-07-30 - Jul Release milestone Jun 18, 2024
@geospatialem geospatialem added p - high Issue should be addressed in the current milestone, impacts component or core functionality estimate - 5 A few days of work, definitely requires updates to tests. and removed p - medium Issue is non core or affecting less that 60% of people using the library labels Jun 18, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned Elijbet Jul 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 8, 2024

Installed and assigned for verification.

@DitwanP
Copy link
Contributor

DitwanP commented Jul 8, 2024

🍡 Verified locally on 'dev'

@DitwanP DitwanP closed this as completed Jul 8, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jul 8, 2024
@DitwanP
Copy link
Contributor

DitwanP commented Jul 9, 2024

Forgive me @Elijbet, reopening to add controls for scale to the simple story on Storybook.

@DitwanP DitwanP reopened this Jul 9, 2024
@DitwanP DitwanP added 2 - in development Issues that are actively being worked on. and removed 4 - verified Issues that have been released and confirmed resolved. labels Jul 9, 2024
@DitwanP DitwanP assigned Elijbet and unassigned geospatialem and DitwanP Jul 9, 2024
@DitwanP DitwanP mentioned this issue Jul 9, 2024
Merged
DitwanP added a commit that referenced this issue Jul 9, 2024
@DitwanP
test(panel, flow-item): add scale control to simple stories (#9747)
3319135 
**Related Issue:** #6980 

## Summary
Adding scale control to the simple stories on storybook
@DitwanP DitwanP added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jul 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@github-actions github-actions bot assigned DitwanP and unassigned Elijbet Jul 10, 2024
@DitwanP DitwanP mentioned this issue Jul 12, 2024
Closed
@DitwanP
Copy link
Contributor

DitwanP commented Jul 12, 2024

🍡Verified, Part 2 🍿

@DitwanP DitwanP closed this as completed Jul 12, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jul 12, 2024
calcite-admin pushed a commit that referenced this issue Jul 30, 2024
@Elijbet @github-actions
feat(panel, flow-item): add scale property (#9730)
27c597e 
**Related Issue:** #6980

## Summary
Add `scale` property to `panel` and `flow-item`.
calcite-admin pushed a commit that referenced this issue Jul 30, 2024
@DitwanP @github-actions
test(panel, flow-item): add scale control to simple stories (#9747)
2f9c63b 
**Related Issue:** #6980 

## Summary
Adding scale control to the simple stories on storybook
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 5 A few days of work, definitely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - high Issue should be addressed in the current milestone, impacts component or core functionality ready for dev Issues ready for development implementation.
Projects
None yet
Milestone
2024-07-31 - Jul Release
Development

No branches or pull requests
8 participants
@driskull @macandcheese @geospatialem @asangma @Elijbet @SkyeSeitz @DitwanP @brittneytewks