test(panel, flow-item): add scale control to simple stories #9747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DitwanP
added
the
pr ready for visual snapshots
driskull
approved these changes
Jul 9, 2024
geospatialem
reviewed
Jul 9, 2024
There was a problem hiding this comment.
@DitwanP Since the change relates to Storybook and not the code base, could you modify the convention type from feat to chore or another type as you see fit?
|
It should probably be |
DitwanP
changed the title
DitwanP
deleted the
dit13711/flowItem-and-panel-add-control-to-storybook-for-new-scale-prop
branch
benelan
added a commit
that referenced
this pull request
Jul 11, 2024
…-monorepo * origin/dev: (104 commits) test(panel, flow-item): add scale control to simple stories (#9747) chore: release next feat(panel, flow-item): add scale property (#9730) chore: release next fix(segmented-control): Make check state update correctly (#9733) chore(date-picker): add messages for select menu label (#9724) chore: release next feat(icon): type icon names (#9650) chore(date-picker): add wide month name for `en-CA` locale (#9723) chore: release next fix(block-section): apply missing CSS class to start/end icon (#9688) chore: release next fix(flow-item): set closed property to true when internal panel is closed (#9715) chore(linting): enable stylelint's length-zero-no-unit rule (#9124) chore: release next fix: fix issue in Firefox where disabled elements were incorrectly enabled when a sibling was enabled (#9710) ci(release-please): use default label to identify PRs (#9708) build: update browserslist db (#9637) build(deps): update dependency eslint-plugin-jsdoc to v48.4.0 (#9696) docs: update component READMEs (#9704) ...
|
@DitwanP seeing the following TS errors on these two stories:
can you open a PR to fix? Scale should be added here: interface PanelStoryArgs
extends Pick<
Panel,
"closed" | "disabled" | "closable" | "collapsed" | "collapsible" | "collapseDirection" | "loading"
> {
heightScale: string;
}Can you make sure that your IDE is reporting the error? |
benelan
added a commit
that referenced
this pull request
Jul 15, 2024
…-to-monorepo * origin/dev: (206 commits) fix(tile): center align slot's text when alignment is equal to center (#9773) build: regenerate package lock due to build errors (#9774) build(deps): update dependency @floating-ui/dom to v1.6.7 (#9766) chore(common-tests): add themed test helper (#9763) chore: release next fix(shell): update shell to correctly position calcite shell panel at shell's bottom (#9748) chore: release next fix(tile): center align contentTop and contentBottom slots when alignment prop equals "center" (#9732) chore: release next chore(tree-item): fix mutable warning `indeterminate` prop (#9760) fix(panel, flow-item): fix footer-padding CSS prop regression (#9757) build(deps): update angular monorepo to v18 (major) (#9587) chore: release next Chore: remove component usage files (#9052) fix(input-number): restore decimal input mode default (#9741) test(panel, flow-item): add scale control to simple stories (#9747) chore: release next feat(panel, flow-item): add scale property (#9730) chore: release next fix(segmented-control): Make check state update correctly (#9733) ...
calcite-admin
pushed a commit
that referenced
this pull request
Jul 30, 2024
**Related Issue:** #6980 ## Summary Adding scale control to the simple stories on storybook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #6980
Summary
Adding scale control to the simple stories on storybook