-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(common-tests): add themed test helper #9763
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfranco
added
the
skip visual snapshots
Pull requests that do not need visual regression testing.
label
Jul 12, 2024
github-actions
bot
added
the
chore
Issues with changes that don't modify src or test files.
label
Jul 12, 2024
driskull
approved these changes
Jul 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
target: TargetInfo; | ||
|
||
/** | ||
* @todo doc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add this doc now?
alisonailea
approved these changes
Jul 12, 2024
benelan
added a commit
that referenced
this pull request
Jul 15, 2024
…-to-monorepo * origin/dev: (206 commits) fix(tile): center align slot's text when alignment is equal to center (#9773) build: regenerate package lock due to build errors (#9774) build(deps): update dependency @floating-ui/dom to v1.6.7 (#9766) chore(common-tests): add themed test helper (#9763) chore: release next fix(shell): update shell to correctly position calcite shell panel at shell's bottom (#9748) chore: release next fix(tile): center align contentTop and contentBottom slots when alignment prop equals "center" (#9732) chore: release next chore(tree-item): fix mutable warning `indeterminate` prop (#9760) fix(panel, flow-item): fix footer-padding CSS prop regression (#9757) build(deps): update angular monorepo to v18 (major) (#9587) chore: release next Chore: remove component usage files (#9052) fix(input-number): restore decimal input mode default (#9741) test(panel, flow-item): add scale control to simple stories (#9747) chore: release next feat(panel, flow-item): add scale property (#9730) chore: release next fix(segmented-control): Make check state update correctly (#9733) ...
calcite-admin
pushed a commit
that referenced
this pull request
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
chore
Issues with changes that don't modify src or test files.
skip visual snapshots
Pull requests that do not need visual regression testing.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #7180
Summary
Adds
themed
test helper from #8594.