Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(common-tests): add themed test helper #9763

Merged
merged 2 commits into from
Jul 13, 2024
Merged

Conversation

jcfranco
Copy link
Member

Related Issue: #7180

Summary

Adds themed test helper from #8594.

@jcfranco jcfranco requested a review from a team as a code owner July 12, 2024 16:56
@jcfranco jcfranco added the skip visual snapshots Pull requests that do not need visual regression testing. label Jul 12, 2024
@github-actions github-actions bot added the chore Issues with changes that don't modify src or test files. label Jul 12, 2024
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

target: TargetInfo;

/**
* @todo doc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add this doc now?

@jcfranco jcfranco merged commit 3cf904a into dev Jul 13, 2024
9 checks passed
@jcfranco jcfranco deleted the jcfranco/add-themed-helper branch July 13, 2024 00:52
@github-actions github-actions bot added this to the 2024-07-30 - Jul Release milestone Jul 13, 2024
benelan added a commit that referenced this pull request Jul 15, 2024
…-to-monorepo

* origin/dev: (206 commits)
  fix(tile): center align slot's text when alignment is equal to center (#9773)
  build: regenerate package lock due to build errors (#9774)
  build(deps): update dependency @floating-ui/dom to v1.6.7 (#9766)
  chore(common-tests): add themed test helper (#9763)
  chore: release next
  fix(shell): update shell to correctly position calcite shell panel at shell's bottom (#9748)
  chore: release next
  fix(tile): center align contentTop and contentBottom slots when alignment prop equals "center" (#9732)
  chore: release next
  chore(tree-item): fix mutable warning `indeterminate` prop (#9760)
  fix(panel, flow-item): fix footer-padding CSS prop regression (#9757)
  build(deps): update angular monorepo to v18 (major) (#9587)
  chore: release next
  Chore: remove component usage files (#9052)
  fix(input-number): restore decimal input mode default (#9741)
  test(panel, flow-item): add scale control to simple stories (#9747)
  chore: release next
  feat(panel, flow-item): add scale property (#9730)
  chore: release next
  fix(segmented-control): Make check state update correctly (#9733)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issues with changes that don't modify src or test files. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants