This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 0
fix: do not remove last identity provider #7739
Merged
HexaField
merged 4 commits into
EtherealEngine:dev
from
aditya-mitra:fix/delete-identity-providers
Mar 17, 2023
Merged
fix: do not remove last identity provider #7739
HexaField
merged 4 commits into
EtherealEngine:dev
from
aditya-mitra:fix/delete-identity-providers
Mar 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HexaField
suggested changes
Mar 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, we should also ensure this in the backend service.
HexaField
approved these changes
Mar 14, 2023
barankyle
reviewed
Mar 15, 2023
packages/server-core/src/user/identity-provider/identity-provider.test.ts
Show resolved
Hide resolved
barankyle
reviewed
Mar 15, 2023
packages/server-core/src/user/identity-provider/identity-provider.test.ts
Outdated
Show resolved
Hide resolved
barankyle
reviewed
Mar 16, 2023
packages/server-core/src/user/identity-provider/identity-provider.hooks.ts
Show resolved
Hide resolved
…t.id & tests: remove identity provider by id
barankyle
reviewed
Mar 17, 2023
packages/client-core/src/user/components/UserMenu/menus/ProfileMenu.tsx
Outdated
Show resolved
Hide resolved
barankyle
approved these changes
Mar 17, 2023
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
identity-provider service
tests to useuserId
instead ofproviders
array. (assert should not be done inside a loop)References
Closes #7575
Checklist
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.