Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

fix: do not remove last identity provider #7739

Merged

Conversation

aditya-mitra
Copy link
Collaborator

@aditya-mitra aditya-mitra commented Mar 12, 2023

Summary

  • Do not show the OAuth Identity Provider for removal if it is the only one present.
  • Also, added the check in server-core along with corresponding tests.
  • Refactored identity-provider service tests to use userId instead of providers array. (assert should not be done inside a loop)

References

Closes #7575

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewer

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Copy link
Member

@HexaField HexaField left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, we should also ensure this in the backend service.

@aditya-mitra aditya-mitra self-assigned this Mar 12, 2023
@HexaField HexaField self-requested a review March 16, 2023 00:46
…t.id & tests: remove identity provider by id
@barankyle barankyle self-requested a review March 17, 2023 18:56
@HexaField HexaField added this pull request to the merge queue Mar 17, 2023
@HexaField HexaField merged commit c73dfdd into EtherealEngine:dev Mar 17, 2023
@aditya-mitra aditya-mitra deleted the fix/delete-identity-providers branch March 18, 2023 05:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Users can delete last identity-provider
3 participants