Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

improve: do not allow to bulk remove identity providers #7772

Merged
merged 2 commits into from
Mar 21, 2023

Conversation

aditya-mitra
Copy link
Collaborator

Summary

Identity Providers should not be allowed to be removed in bulk via API.
Remove identity provider only if id is present (i.e. only allow single remove)
Made corresponding changes for the unit tests

References

Refs #7739 (comment)

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewer

QA Steps

@speigg
Copy link
Member

speigg commented Mar 20, 2023

@cla-bot check

@cla-bot
Copy link

cla-bot bot commented Mar 20, 2023

Thank you for your pull request and welcome to the Ethereal Engine developer community!

We require contributors to sign our Copyright Assignment Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign the agreement at https://forms.gle/15ENsSAJGKf2ozvB7

The agreement has not been signed by users: @aditya-mitra.

After signing the agreement, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR :)

@cla-bot
Copy link

cla-bot bot commented Mar 20, 2023

Rechecking to see that all contributors are verified.

@HexaField
Copy link
Member

@cla-bot check

@cla-bot
Copy link

cla-bot bot commented Mar 21, 2023

Checking that all contributors to this PR are verified.

@HexaField HexaField added this pull request to the merge queue Mar 21, 2023
@HexaField HexaField removed this pull request from the merge queue due to a manual request Mar 21, 2023
@HexaField HexaField merged commit 33dce73 into EtherealEngine:dev Mar 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants