-
-
Notifications
You must be signed in to change notification settings - Fork 0
8133 studio should have render settings exposed #8263
8133 studio should have render settings exposed #8263
Conversation
…into 8133-studio-should-have-render-settings-exposed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is what was meant by render settings, not the scene render settings. We should buff this out into a modal instead of a dropdown, and include the post processing button.
We then need to add conditions in all the places where the render settings affect the renderer, to use these new editor settings instead of user profile settings when in the editor.
Understood, I'm on it, do we also want the settings to disappear from the user config when in editor mode? |
packages/editor/src/components/properties/RenderSettingsEditor.tsx
Outdated
Show resolved
Hide resolved
|
for the modal itself, it will appear as a popup box, in the center of screen, taking the focus click outside of modal to return , or i can add a close button as far as i know, the resolution is for overall graphics EDIT: i handnt pulled latest changes, i understood what shadow map resolution means now, ill adjust the modal accordingly regarding the changes i made earlier in the scene render settings, should i keep them or revert them, ill revert them if asked to |
…ps://github.com/EtherealEngine/etherealengine into 8133-studio-should-have-render-settings-exposed
…into 8133-studio-should-have-render-settings-exposed
…ps://github.com/EtherealEngine/etherealengine into 8133-studio-should-have-render-settings-exposed
Summary
added fully fleshed checkboxes
References
closes #insert number here
Checklist
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.