[feature] add configurable behavior when session ends #8206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ior when session ends
Eugeny
requested changes
Apr 13, 2023
Clem-Fern
changed the title
|
Hi @Eugeny :) As discuss, I've made the changes requested. You can now select 4 different options to choose how the tab should behave when a session ends.
I voluntarily set the default mode to Feel free to ask if any changes are required. |
Clem-Fern
changed the title
Eugeny
approved these changes
Apr 24, 2023
|
LGTM, thank you! I'll keep testing it the next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @Eugeny,
This PR adds different tab's behaviors on session ending.
As asked in #6617, #7751 and #8062, you can choose to keep the tab opened after you got disconnected or exited the shell. You can also choose to automatically reconnect the session or close the tab.
I didn't add the ability to configure this feature independently on each profile, but i can definitely take a look if you think it could be useful.
Feel free to ask if any changes are required.