[feature] add reconnect tab to command palette and hotkey #8201
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @Eugeny,
This PR adds reconnect command into the palette like asked in #7723.
In the view to add this feature in the most generic way, I choose to create an interface named
Reconnectable
which Serial, Telnet and SSH tab component are implementing. With this approach, the reconnect command in only added if the current tab can be reconnected. It works as expected but as I am not really familiar with interface in typescript, I let you tell me if it is a correct way to proceed or not...A more simple way would probably be to provide a context menu for each reconnectable tab (in tabby-serial, tabby-ssh and tabby-telnet).
Secondly, I also added an hotkey to reconnect the current tab. I saw that a restart tab hotkey already exists but it duplicates the current tab and close the old one. Since the restart and reconnect are two different behaviors and reconnect applicable to serial/ssh/telnet only, I thought it could be interesting to have the two options.
I hope i didn't miss anything this time, feel free to ask if any change needed.