Refactoring connectable tab #8416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, sorry for the delay! I've gone through the PR and it looks great! I think the old interface can be removed too - I'm not aware of any plugins using it. |
|
No problem, glad to hear that :) |
|
Looking good! |
Clem-Fern
added a commit
to Clem-Fern/tabby
that referenced
this pull request
Aug 14, 2023
…nectableProfileProvider Eugeny#8416
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @Eugeny, hope you're doing well
As discuss in #8201, I've tried to refactor ssh, serial and telnet tab component and created a connectable base class.
All commits were made and tested meticulously to try to avoid any breaking change.
I voluntarily left the
Reconnectableinterface but it can probably be deleted. Same forrestart-telnet-session,restart-telnet-sessionandrestart-telnet-session, since there are a globalreconnecthotkey for connectable tab.I won't sure there be any good to take in this PR but I have done my best ahah :D
Could you, please, give me a feedback on this?