-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various fix/enhancement about Profiles #8726
Conversation
LGTM so far 👍 |
Hey @Eugeny, I've done a bit of refactoring on Profile & ProfileGroup system, I tried to move all the interaction (creation, update, deletion) with Profile and ProfileGroup in ProfileService as discuss in #8663. My goal is to make maintenance and future work easier by having only one entrypoint for profile operation. With the methods in the core service, It will allow me to remove direct access to I also tried to prepare implementation of #3999, #3880, #7265 and #6650 by reworking ProfileGroup. Should I create a dedicated service for Group ? (ProfileGroupService for example) Could you, please, take a look when you got the time ? Even if I'm far from done, I would reallly like to have your feedback on this :) . |
Wow! I haven't had time to review it in detail yet, but I like your direction. Small nitpick: I wouldn't keep the collapsed status in the config, it's only relevant for the profileSettingsTab anyway. One thing to keep in mind (now that you have 3 config "levels") is what's going to happen if a profile setting is changed to non-default in the group config, but then is changed back to default in one of its profiles. Right now ConfigProxy will remove the value completely since it matches the defaults. You'll need to make sure that |
Glad to hear that ! ;)
Oh yeah, seems obvious now you say it.
I haven't really looked into it yet but it was my next step planned. |
When a profile is updated, the group attribute is set to |
…t hosts inherit
No problem, there's absolutely no rush. I got two more issues I would like to address so I will stop adding new commit soon anyway. It's a good first step for me I think and I really don't want to make this PR a chore to review for you :) |
…ect option on connectable profile
…OnConnect ssh option
ef6b8a4 : I made a bit of refactoring to be aligned with my previous PR #8416. I created an interface named ef6b8a4 : I added a new property in 5eeaef9 : I removed the old Edit 18/08: |
Fix #8065 a9c63b5: This commit fixes the issue #8065. While trying to understand why some button became unresponsive when Even if unhandled rejection on modal dismissed does not seem to have impact anywhere else than for #8065, I also tried to add a No more addition planned on this PR. From now, I will only add fix on what I've done if needed :) |
I've gone through it and left some nitpicks here and there but all in all the PR looks great already 👍 |
Phew what a huge merge 😅 |
Phew what a huge merge 😅 |
Hey, I'm sorry, I didn't have the time to respond and fix everything in one time... Refactoring profiles service was the first step to achieve before being able to work on profiles/groups tree hierarchy. I would like to work on this next (if you agree ofc). |
Thanks for undertaking the work haha I'm fine with nested groups as long as it's not negatively affecting the "normal" case that 90% of users will have (no nested groups), e.g. so that the profile selector doesn't end up being some unwieldy MobaXTerm-esque control |
Hi @Eugeny, hope you're doing great !
I'm currently working on a small list of issues which are related to Profiles and that I want to try to address. I'm opening this draft to keep track on my progress, and I will probably ask for your opinion on the way to implement some feature if you are ok with that.
Resolve #7057 4dedbbc: As
recentProfiles
already are sort by most recent used profile, I simply add weight on theSelectorOption
based on the profile index in therecentProfiles
array.Fix #8709 d57757c: I made a small mistake previously. The weight I added on the
Connect to
selector option were not used in theonFilterChange
function inselectorModal
component.Edit 11/08:
Resolve #3999 695c5ba : allow users to specify settings on profile group for each profile provider
Edit 12/08
Resolve #7265 f369b14 : added a button to reset global default profile settings and to restore inherited settings on a group.
Edit 15/08
Fix #8065 a9c63b5: This commit fixes the issue #8065. Resolve the returned Promise in showProfileSelector when selector modal is dismissed.