Fix#8912: clear SSH service messages not working #8918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM 🚀 |
LGTM 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @Eugeny, I hope you are doing well.
This PR aims to fix the issue #8912. By adding a global connectable tab option for
clearServiceMessagesOnConnectin #8726 ef6b8a4, I placed the fronted clear call before the session finishes initializing. It results in only cleaning latest terminal session log on reconnection and not service message on connection, which, I think, is not wanted from what I see in #7841.Feel free to ask if any change are needed.
Resolve #8912