Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat#8680: add "connect to" option in profile selector for each provider supporting quick connect #8709

Merged
merged 5 commits into from
Jul 18, 2023

Conversation

Clem-Fern
Copy link
Contributor

Hi @Eugeny :)

As discuss in #8680, this PR aims to add "connect to" option in profile selector for each provider supporting quick connect:
image

Should we create a configuration to put weight on "connect to" option? It would allow users to choose which "Connect to" option have to be on top of the list according to their habit.

Feel free to ask me if changes needed!

Resolve #8680

@Clem-Fern Clem-Fern changed the title Feat#8680 Feat#8680: add "connect to" option in profile selector for each provider supporting quick connect Jul 15, 2023
@Eugeny
Copy link
Owner

Eugeny commented Jul 18, 2023

I think that's a good idea seeing as how currently Telnet ends up on top :D
We don't need a full priority reorder UI, just a single option to select the preferred "default" connect-to provider is enough (you can put it in Settings -> Profiles -> Advanced, it should be SSH by default)

@Clem-Fern
Copy link
Contributor Author

We don't need a full priority reorder UI, just a single option to select the preferred "default" connect-to provider is enough (you can put it in Settings -> Profiles -> Advanced, it should be SSH by default)

Yeah, that's totally what I had in mind. I will add some commit for this in the next days.

@Eugeny
Copy link
Owner

Eugeny commented Jul 18, 2023

Thanks!

@Clem-Fern
Copy link
Contributor Author

As discuss :)
image

Not quite sure about the name and description I should add for this option by the way '^^

@Eugeny
Copy link
Owner

Eugeny commented Jul 18, 2023

Nice!

@Eugeny Eugeny merged commit 8b89db4 into Eugeny:master Jul 18, 2023
10 checks passed
Clem-Fern added a commit to Clem-Fern/tabby that referenced this pull request Jul 20, 2023
@Clem-Fern Clem-Fern deleted the feat#8680 branch August 4, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "connect to" option to type-specific profile selectors
2 participants